dany/facetimehd
1
0
Fork 0
mirror of https://github.com/patjak/facetimehd.git synced 2026-04-10 03:20:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

fthd: Fix some FIXMEs

Browse Source 
Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
This commit is contained in:
Patrik Jakobsson
2016-07-04 01:14:41 +02:00
parent 45bccf0a30
commit 187ec0c872
3 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
fthd_isp.c
View File

@@ -319,8 +319,10 @@ static int fthd_isp_cmd(struct fthd_private *dev_priv, enum fthd_isp_cmds comman
request_size = FTHD_S2_MEM_READ(entry + FTHD_RINGBUF_REQUEST_SIZE);
response_size = FTHD_S2_MEM_READ(entry + FTHD_RINGBUF_RESPONSE_SIZE);
/* XXX: response size in the ringbuf is zero after command completion, how is buffer size
verification done? */
/*
* FIXME: response size in the ringbuf is zero after command completion,
* how is buffer size verification done?
*/
if (response_len && *response_len)
FTHD_S2_MEMCPY_FROMIO(buf, (address & ~3) + sizeof(struct isp_cmd_hdr),
*response_len);
@@ -397,7 +399,7 @@ int fthd_isp_debug_cmd(struct fthd_private *dev_priv, enum fthd_isp_cmds command
/*
* FIXME: response size in the ringbuf is zero after command completion,
* how is buffer size verification done?
**/
*/
if (response_len && *response_len)
FTHD_S2_MEMCPY_FROMIO(buf, (address & ~3) + sizeof(struct isp_cmd_hdr),
*response_len);
@@ -1295,10 +1297,6 @@ int isp_init(struct fthd_private *dev_priv)
FTHD_ISP_REG_WRITE(0xffffffff, ISP_IRQ_CLEAR);
/*
* Probably the IPC queue
* FIXME: Check if we can do 64bit writes on PCIe
*/
for (i = ISP_FW_CHAN_START; i <= ISP_FW_CHAN_END; i += 8) {
FTHD_ISP_REG_WRITE(0xffffffff, i);
FTHD_ISP_REG_WRITE(0, i + 4);

5
fthd_isp.h
View File

@@ -468,7 +468,8 @@ enum isp_debug_cmds {
CISP_CMD_DEBUG_GET_FSM_BY_NAME,
CISP_CMD_DEBUG_GET_FSM_DEBUG_LEVEL,
CISP_CMD_DEBUG_SET_FSM_DEBUG_LEVEL,
CISP_CMD_DEBUG_FSM_UNKNOWN, /* XXX: don't know what this cmd is doing yet */
/* FIXME: don't know what this cmd is doing yet */
CISP_CMD_DEBUG_FSM_UNKNOWN,
CISP_CMD_DEBUG_HEAP_STATISTICS,
CISP_CMD_DEBUG_IRQ_STATISTICS,
CISP_CMD_DEBUG_SHOW_SEMAPHORE_STATUS,
@@ -494,7 +495,7 @@ struct isp_fw_args {
};
struct isp_channel_info {
char name[64]; /* really that big? */
char name[64];
u32 type;
u32 source;
u32 size;

2
fthd_v4l2.c
View File

@@ -721,7 +721,7 @@ int fthd_v4l2_register(struct fthd_private *dev_priv)
dev_priv->alloc_ctx = vb2_dma_sg_init_ctx(&dev_priv->pdev->dev);
vdev->v4l2_dev = v4l2_dev;
strcpy(vdev->name, "Apple Facetime HD"); // XXX: Length?
strcpy(vdev->name, "Apple Facetime HD"); /* FIXME: Length? */
vdev->vfl_dir = VFL_DIR_RX;
vdev->fops = &fthd_vdev_fops;
vdev->ioctl_ops = &fthd_ioctl_ops;