From 187ec0c872a4d2fa38746583492a05e728ff0834 Mon Sep 17 00:00:00 2001 From: Patrik Jakobsson Date: Mon, 4 Jul 2016 01:14:41 +0200 Subject: [PATCH] fthd: Fix some FIXMEs Signed-off-by: Patrik Jakobsson --- fthd_isp.c | 12 +++++------- fthd_isp.h | 5 +++-- fthd_v4l2.c | 2 +- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/fthd_isp.c b/fthd_isp.c index 6e294b3..f8dc4f6 100644 --- a/fthd_isp.c +++ b/fthd_isp.c @@ -319,8 +319,10 @@ static int fthd_isp_cmd(struct fthd_private *dev_priv, enum fthd_isp_cmds comman request_size = FTHD_S2_MEM_READ(entry + FTHD_RINGBUF_REQUEST_SIZE); response_size = FTHD_S2_MEM_READ(entry + FTHD_RINGBUF_RESPONSE_SIZE); - /* XXX: response size in the ringbuf is zero after command completion, how is buffer size - verification done? */ + /* + * FIXME: response size in the ringbuf is zero after command completion, + * how is buffer size verification done? + */ if (response_len && *response_len) FTHD_S2_MEMCPY_FROMIO(buf, (address & ~3) + sizeof(struct isp_cmd_hdr), *response_len); @@ -397,7 +399,7 @@ int fthd_isp_debug_cmd(struct fthd_private *dev_priv, enum fthd_isp_cmds command /* * FIXME: response size in the ringbuf is zero after command completion, * how is buffer size verification done? - **/ + */ if (response_len && *response_len) FTHD_S2_MEMCPY_FROMIO(buf, (address & ~3) + sizeof(struct isp_cmd_hdr), *response_len); @@ -1295,10 +1297,6 @@ int isp_init(struct fthd_private *dev_priv) FTHD_ISP_REG_WRITE(0xffffffff, ISP_IRQ_CLEAR); - /* - * Probably the IPC queue - * FIXME: Check if we can do 64bit writes on PCIe - */ for (i = ISP_FW_CHAN_START; i <= ISP_FW_CHAN_END; i += 8) { FTHD_ISP_REG_WRITE(0xffffffff, i); FTHD_ISP_REG_WRITE(0, i + 4); diff --git a/fthd_isp.h b/fthd_isp.h index 8cbcdf8..a7b5879 100644 --- a/fthd_isp.h +++ b/fthd_isp.h @@ -468,7 +468,8 @@ enum isp_debug_cmds { CISP_CMD_DEBUG_GET_FSM_BY_NAME, CISP_CMD_DEBUG_GET_FSM_DEBUG_LEVEL, CISP_CMD_DEBUG_SET_FSM_DEBUG_LEVEL, - CISP_CMD_DEBUG_FSM_UNKNOWN, /* XXX: don't know what this cmd is doing yet */ + /* FIXME: don't know what this cmd is doing yet */ + CISP_CMD_DEBUG_FSM_UNKNOWN, CISP_CMD_DEBUG_HEAP_STATISTICS, CISP_CMD_DEBUG_IRQ_STATISTICS, CISP_CMD_DEBUG_SHOW_SEMAPHORE_STATUS, @@ -494,7 +495,7 @@ struct isp_fw_args { }; struct isp_channel_info { - char name[64]; /* really that big? */ + char name[64]; u32 type; u32 source; u32 size; diff --git a/fthd_v4l2.c b/fthd_v4l2.c index a36dfd9..6a91a32 100644 --- a/fthd_v4l2.c +++ b/fthd_v4l2.c @@ -721,7 +721,7 @@ int fthd_v4l2_register(struct fthd_private *dev_priv) dev_priv->alloc_ctx = vb2_dma_sg_init_ctx(&dev_priv->pdev->dev); vdev->v4l2_dev = v4l2_dev; - strcpy(vdev->name, "Apple Facetime HD"); // XXX: Length? + strcpy(vdev->name, "Apple Facetime HD"); /* FIXME: Length? */ vdev->vfl_dir = VFL_DIR_RX; vdev->fops = &fthd_vdev_fops; vdev->ioctl_ops = &fthd_ioctl_ops;