dany/u-boot-megous
1
0
Fork 0
mirror of https://xff.cz/git/u-boot/ synced 2026-04-10 05:39:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

easylogo: avoid buffer overrun

Browse Source 
Building easylogo with `HOST_TOOLS_ALL=y make tools` results in a build
warning due to a possible buffer overrun:

tools/easylogo/easylogo.c:453:4: note: ‘sprintf’ output between 7 and
262 bytes into a destination of size 256
    sprintf (str, "%s, 0x%02x", app, *dataptr++);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Truncate the output to fit into the destination buffer.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
This commit is contained in:
Heinrich Schuchardt
2019-08-15 23:54:15 +02:00
committed by Lukasz Majewski
parent 071f369dd2
commit 2bdb42f7c0
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tools/easylogo/easylogo.c
View File

@@ -450,7 +450,8 @@ int image_save_header (image_t * image, char *filename, char *varname)
default:
strcpy (app, str);
sprintf (str, "%s, 0x%02x", app, *dataptr++);
sprintf(str, "%.*s, 0x%02x", (int)sizeof(str) - 7, app,
*dataptr++);
col++;
count--;
break;