dany/libwebp
1
0
Fork 0
mirror of https://github.com/webmproject/libwebp.git synced 2024-12-26 13:48:21 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

remove some minor TODOs

Browse Source 
if we didn't do these, they were probably non vital.

Change-Id: I952d2351f5c71934247d4d6631cfdfe070f76bf5
This commit is contained in:
Pascal Massimino 2018-10-17 10:48:19 +02:00
parent cbf82cc04d
commit 981794958b
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/dec/frame_dec.c
View File

@ -338,7 +338,6 @@ void VP8InitDithering(const WebPDecoderOptions* const options,
for (s = 0; s < NUM_MB_SEGMENTS; ++s) { for (s = 0; s < NUM_MB_SEGMENTS; ++s) {
VP8QuantMatrix* const dqm = &dec->dqm_[s]; VP8QuantMatrix* const dqm = &dec->dqm_[s];
if (dqm->uv_quant_ < DITHER_AMP_TAB_SIZE) { if (dqm->uv_quant_ < DITHER_AMP_TAB_SIZE) {
// TODO(skal): should we specially dither more for uv_quant_ < 0?
const int idx = (dqm->uv_quant_ < 0) ? 0 : dqm->uv_quant_; const int idx = (dqm->uv_quant_ < 0) ? 0 : dqm->uv_quant_;
dqm->dither_ = (f * kQuantToDitherAmp[idx]) >> 3; dqm->dither_ = (f * kQuantToDitherAmp[idx]) >> 3;
} }
@ -669,15 +668,9 @@ int VP8GetThreadMethod(const WebPDecoderOptions* const options,
(void)height; (void)height;
assert(headers == NULL || !headers->is_lossless); assert(headers == NULL || !headers->is_lossless);
#if defined(WEBP_USE_THREAD) #if defined(WEBP_USE_THREAD)
if (width < MIN_WIDTH_FOR_THREADS) return 0; if (width >= MIN_WIDTH_FOR_THREADS) return 2;
// TODO(skal): tune the heuristic further
#if 0
if (height < 2 * width) return 2;
#endif #endif
return 2;
#else // !WEBP_USE_THREAD
return 0; return 0;
#endif
} }
#undef MT_CACHE_LINES #undef MT_CACHE_LINES

2
src/enc/analysis_enc.c
View File

@ -458,7 +458,7 @@ static void MergeJobs(const SegmentJob* const src, SegmentJob* const dst) {
dst->uv_alpha += src->uv_alpha; dst->uv_alpha += src->uv_alpha;
} }
// initialize the job struct with some TODOs // initialize the job struct with some tasks to perform
static void InitSegmentJob(VP8Encoder* const enc, SegmentJob* const job, static void InitSegmentJob(VP8Encoder* const enc, SegmentJob* const job,
int start_row, int end_row) { int start_row, int end_row) {
WebPGetWorkerInterface()->Init(&job->worker); WebPGetWorkerInterface()->Init(&job->worker);