From 981794958bed0a3887bbcf5abc7814c658b96d86 Mon Sep 17 00:00:00 2001 From: Pascal Massimino Date: Wed, 17 Oct 2018 10:48:19 +0200 Subject: [PATCH] remove some minor TODOs if we didn't do these, they were probably non vital. Change-Id: I952d2351f5c71934247d4d6631cfdfe070f76bf5 --- src/dec/frame_dec.c | 9 +-------- src/enc/analysis_enc.c | 2 +- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/dec/frame_dec.c b/src/dec/frame_dec.c index a9d5430d..bda9e1a6 100644 --- a/src/dec/frame_dec.c +++ b/src/dec/frame_dec.c @@ -338,7 +338,6 @@ void VP8InitDithering(const WebPDecoderOptions* const options, for (s = 0; s < NUM_MB_SEGMENTS; ++s) { VP8QuantMatrix* const dqm = &dec->dqm_[s]; if (dqm->uv_quant_ < DITHER_AMP_TAB_SIZE) { - // TODO(skal): should we specially dither more for uv_quant_ < 0? const int idx = (dqm->uv_quant_ < 0) ? 0 : dqm->uv_quant_; dqm->dither_ = (f * kQuantToDitherAmp[idx]) >> 3; } @@ -669,15 +668,9 @@ int VP8GetThreadMethod(const WebPDecoderOptions* const options, (void)height; assert(headers == NULL || !headers->is_lossless); #if defined(WEBP_USE_THREAD) - if (width < MIN_WIDTH_FOR_THREADS) return 0; - // TODO(skal): tune the heuristic further -#if 0 - if (height < 2 * width) return 2; + if (width >= MIN_WIDTH_FOR_THREADS) return 2; #endif - return 2; -#else // !WEBP_USE_THREAD return 0; -#endif } #undef MT_CACHE_LINES diff --git a/src/enc/analysis_enc.c b/src/enc/analysis_enc.c index a47ff7d4..687757ae 100644 --- a/src/enc/analysis_enc.c +++ b/src/enc/analysis_enc.c @@ -458,7 +458,7 @@ static void MergeJobs(const SegmentJob* const src, SegmentJob* const dst) { dst->uv_alpha += src->uv_alpha; } -// initialize the job struct with some TODOs +// initialize the job struct with some tasks to perform static void InitSegmentJob(VP8Encoder* const enc, SegmentJob* const job, int start_row, int end_row) { WebPGetWorkerInterface()->Init(&job->worker);