README: add details about config files

at: fix argument order

See merge request mobian1/devices/eg25-manager!9

README.md

@@ -29,13 +29,20 @@ $ ninja -C ../eg25-build
 # ninja -C ../eg25-build install
 ```
 
+## Configuration
+
+`eg25-manager` uses device-specific configuration files, named after the
+device-tree `compatible` field. These files are installed to
+`/usr/share/eg25-manager`. They can be copied to `/etc/eg25-manager` then
+modified, that way they won't be overwritten during an upgrade.
+
 ## Running
 
 `eg25-manager` is usually run as a systemd service, but can also be
 manually started from the command-line (requires root privileges):
 
 ```
-# eg25-manager
+# eg25manager
 ```
 
 ## License

data/pine64,pinephone-1.0.toml

@@ -31,6 +31,7 @@ configure = [
 #               match, the command is then executed with value `expect` in
 #               order to set the parameter to the configured value (optional)
 # A command can have `expect` OR `value` configured, but it shouldn't have both
+    { cmd = "QGMR" },
     { cmd = "QDAI", expect = "1,1,0,1,0,0,1,1" },
     { cmd = "QCFG", subcmd = "risignaltype", expect = "\"physical\"" },
     { cmd = "QCFG", subcmd = "ims", expect = "1" },

data/pine64,pinephone-1.1.toml

@@ -31,6 +31,7 @@ configure = [
 #               match, the command is then executed with value `expect` in
 #               order to set the parameter to the configured value (optional)
 # A command can have `expect` OR `value` configured, but it shouldn't have both
+    { cmd = "QGMR" },
     { cmd = "QDAI", expect = "1,1,0,1,0,0,1,1" },
     { cmd = "QCFG", subcmd = "risignaltype", expect = "\"physical\"" },
     { cmd = "QCFG", subcmd = "ims", expect = "1" },

data/pine64,pinephone-1.2.toml

@@ -27,6 +27,7 @@ configure = [
 #               match, the command is then executed with value `expect` in
 #               order to set the parameter to the configured value (optional)
 # A command can have `expect` OR `value` configured, but it shouldn't have both
+    { cmd = "QGMR" },
     { cmd = "QDAI", expect = "1,1,0,1,0,0,1,1" },
     { cmd = "QCFG", subcmd = "risignaltype", expect = "\"physical\"" },
     { cmd = "QCFG", subcmd = "ims", expect = "1" },

src/at.c

@@ -320,7 +320,7 @@ void at_sequence_configure(struct EG25Manager *manager)
 {
     for (guint i = 0; i < configure_commands->len; i++) {
         struct AtCommand *cmd = &g_array_index(configure_commands, struct AtCommand, i);
-        append_at_command(manager, cmd->cmd, cmd->subcmd, cmd->expected, cmd->value);
+        append_at_command(manager, cmd->cmd, cmd->subcmd, cmd->value, cmd->expected);
     }
     send_at_command(manager);
 }
@@ -329,7 +329,7 @@ void at_sequence_suspend(struct EG25Manager *manager)
 {
     for (guint i = 0; i < suspend_commands->len; i++) {
         struct AtCommand *cmd = &g_array_index(suspend_commands, struct AtCommand, i);
-        append_at_command(manager, cmd->cmd, cmd->subcmd, cmd->expected, cmd->value);
+        append_at_command(manager, cmd->cmd, cmd->subcmd, cmd->value, cmd->expected);
     }
     send_at_command(manager);
 }
@@ -338,7 +338,7 @@ void at_sequence_resume(struct EG25Manager *manager)
 {
     for (guint i = 0; i < resume_commands->len; i++) {
         struct AtCommand *cmd = &g_array_index(resume_commands, struct AtCommand, i);
-        append_at_command(manager, cmd->cmd, cmd->subcmd, cmd->expected, cmd->value);
+        append_at_command(manager, cmd->cmd, cmd->subcmd, cmd->value, cmd->expected);
     }
     send_at_command(manager);
 }
@@ -347,7 +347,7 @@ void at_sequence_reset(struct EG25Manager *manager)
 {
     for (guint i = 0; i < reset_commands->len; i++) {
         struct AtCommand *cmd = &g_array_index(reset_commands, struct AtCommand, i);
-        append_at_command(manager, cmd->cmd, cmd->subcmd, cmd->expected, cmd->value);
+        append_at_command(manager, cmd->cmd, cmd->subcmd, cmd->value, cmd->expected);
     }
     send_at_command(manager);
 }