dany/clapper
1
0
Fork 0
mirror of https://github.com/Rafostar/clapper.git synced 2025-08-29 15:22:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

gst-plugin: Avoid GTK crash after context is destroyed

Browse Source 
It seems GTK continues using created contexts, so we cannot unref it here.
Looking at GTK sink implementation for GtkVideo, I see that they do not
unref it either, but since we use surfaceless context it would be probably
better to have a static GstDisplay and reuse the same context in future.
This commit is contained in:
Rafał Dzięgiel
2024-05-02 11:12:02 +02:00
parent 35527e5c14
commit b1613273d0
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/lib/gst/plugin/handlers/gl/gstclapperglcontexthandler.c
View File

@@ -473,7 +473,12 @@ gst_clapper_gl_context_handler_finalize (GObject *object)
gst_clear_object (&self->gst_display);
gst_clear_object (&self->wrapped_context);
gst_clear_object (&self->gst_context);
/* FIXME: It seems GTK continues using created contexts, so we cannot unref
* it here. Looking at GTK sink implementation for GtkVideo, I see that they
* do not unref it either, but since we use surfaceless context it would be
* probably better to have a static GstDisplay and reuse the same context. */
//gst_clear_object (&self->gst_context);
GST_CALL_PARENT (G_OBJECT_CLASS, finalize, (object));
}