mirror of
				https://xff.cz/git/u-boot/
				synced 2025-10-31 10:26:10 +01:00 
			
		
		
		
	The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
		
			
				
	
	
		
			26 lines
		
	
	
		
			443 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			26 lines
		
	
	
		
			443 B
		
	
	
	
		
			C
		
	
	
	
	
	
| // SPDX-License-Identifier: GPL-2.0+
 | |
| /*
 | |
|  * Copyright 2007-2011 Freescale Semiconductor, Inc.
 | |
|  */
 | |
| 
 | |
| #include <common.h>
 | |
| #include <command.h>
 | |
| #include <init.h>
 | |
| #include <pci.h>
 | |
| #include <asm/fsl_pci.h>
 | |
| #include <linux/libfdt.h>
 | |
| #include <fdt_support.h>
 | |
| #include <asm/fsl_serdes.h>
 | |
| 
 | |
| #if !defined(CONFIG_DM_PCI)
 | |
| void pci_init_board(void)
 | |
| {
 | |
| 	fsl_pcie_init_board(0);
 | |
| }
 | |
| 
 | |
| void pci_of_setup(void *blob, struct bd_info *bd)
 | |
| {
 | |
| 	FT_FSL_PCI_SETUP;
 | |
| }
 | |
| #endif
 |