1
0
mirror of https://xff.cz/git/u-boot/ synced 2026-02-13 08:49:28 +01:00
Files
u-boot-megous/include
Jonas Karlman eb84ee977d mmc: Remove alignment hole for cmdidx in struct mmc_cmd
The alignment hole caused by cmdidx in struct mmc_cmd cause strange
issues together with the peephole2 optimization on Amlogic SoCs.
Following was observed while working on SPL support for Amlogic SoCs.

sd_get_capabilities() normally issue a CMD55 followed by a CMD51.
However, on at least Amlogic S905 (Cortex-A53) and S905X3 (Cortex-A55),
CMD55 was instead followed by CMD8 (and a few reties) in SPL.

Code from the call site:

  cmd.cmdidx = SD_CMD_APP_SEND_SCR; // 51
  ...
  data.blocksize = 8;
  ...
  err = mmc_send_cmd_retry(mmc, &cmd, &data, 3);

Running the code with MMC_TRACE enabled shows:

CMD_SEND:55
                ARG                      0x50480000
                MMC_RSP_R1,5,6,7         0x00000920
CMD_SEND:8
                ARG                      0x00000000
                RET                      -110

Removing the alignment hole by changing cmdidx from ushort to uint or
building with -fno-peephole2 flag seem to resolve this issue.

CMD_SEND:55
                ARG                      0x50480000
                MMC_RSP_R1,5,6,7         0x00000920
CMD_SEND:51
                ARG                      0x00000000
                MMC_RSP_R1,5,6,7         0x00000920

Same issue was observed building U-Boot with gcc 8 - 13.

Remove this alignment hole by changing cmdidx from ushort to uint.

Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
2024-10-08 15:41:08 +02:00
..
2024-07-31 16:51:54 +02:00
2022-10-30 20:07:16 +01:00
2022-01-19 18:11:34 +01:00
2022-09-29 16:07:57 -04:00
2022-09-24 10:47:01 -04:00
2023-08-25 13:54:33 -04:00
2022-07-26 02:30:56 -06:00
2023-08-08 10:22:03 -04:00
2024-07-29 15:01:04 -06:00
2023-12-21 08:54:37 -05:00
2022-01-30 01:25:00 +00:00
2022-01-30 01:25:00 +00:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2024-07-29 15:01:04 -06:00
2022-01-19 18:11:34 +01:00
2024-06-24 13:34:52 -06:00
2022-01-19 18:11:34 +01:00
2024-02-13 15:38:49 -05:00
2024-07-29 15:01:04 -06:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2024-08-02 15:16:51 -03:00
2022-01-19 18:11:34 +01:00
2024-07-31 16:51:54 +02:00
2024-07-29 15:01:04 -06:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2024-07-29 15:01:04 -06:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2024-07-29 15:01:04 -06:00
2024-07-16 17:09:33 -06:00
2024-06-14 12:59:07 -06:00
2022-03-15 16:19:29 -04:00
2022-04-06 14:01:42 -04:00
2024-07-29 15:01:04 -06:00
2023-05-02 14:23:34 -04:00
2022-01-19 18:11:34 +01:00
2024-07-29 15:01:04 -06:00
2022-10-18 09:32:53 +08:00
2023-01-20 12:27:06 -05:00
2024-07-29 15:01:04 -06:00
2024-07-29 15:01:04 -06:00
2022-07-26 11:29:00 +02:00
2024-07-29 15:01:04 -06:00
2023-11-07 14:50:51 -05:00
2024-07-29 15:01:04 -06:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2023-10-31 09:08:51 +01:00
2022-01-19 18:11:34 +01:00
2023-04-27 13:51:06 -04:00
2022-01-19 18:11:34 +01:00
2023-12-21 11:59:49 -05:00
2023-08-19 04:12:53 +02:00
2022-10-30 20:07:17 +01:00
2024-07-29 15:01:04 -06:00
2024-07-29 15:01:04 -06:00
2023-12-21 08:54:37 -05:00
2023-10-11 15:43:55 -04:00
2024-07-29 15:01:04 -06:00
2022-01-24 10:35:10 -05:00
2024-07-29 15:01:04 -06:00
2024-07-29 15:01:04 -06:00
2024-07-29 15:01:04 -06:00
2023-12-21 08:54:37 -05:00
2024-07-29 15:01:04 -06:00
2024-09-21 10:59:52 +02:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2024-08-08 09:28:05 +02:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2024-07-29 15:01:04 -06:00
2022-01-19 18:11:34 +01:00
2024-07-29 15:01:04 -06:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2023-01-16 18:01:10 +08:00
2023-12-21 08:54:37 -05:00
2024-07-29 15:01:04 -06:00
2022-01-19 18:11:34 +01:00
2022-04-01 15:03:13 -04:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2024-07-29 15:01:04 -06:00
2022-01-19 18:11:34 +01:00
2023-11-16 13:49:14 -05:00
2024-07-29 15:01:04 -06:00
2022-04-06 14:03:17 -04:00
2023-10-09 15:24:31 -04:00
2024-05-22 08:55:29 -06:00
2023-02-10 07:41:40 -05:00
2024-07-29 15:01:04 -06:00
2022-01-19 18:11:34 +01:00
2024-06-30 13:58:31 +02:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2024-07-29 15:01:04 -06:00
2022-12-07 16:04:17 -05:00
2024-07-29 15:01:04 -06:00
2024-07-29 15:01:04 -06:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2024-07-31 16:52:51 +02:00
2024-05-22 08:55:29 -06:00
2022-01-19 18:11:34 +01:00
2024-07-29 15:01:04 -06:00