Rasmus Villemoes 50128aeb0f
cyclic: get rid of cyclic_init() ...
Currently, we must call cyclic_init() at some point before
cyclic_register() becomes possible. That turns out to be somewhat
awkward, especially with SPL, and has resulted in a watchdog callback
not being registered, thus causing the board to prematurely reset.
We already rely on gd->cyclic reliably being set to NULL by the asm
code that clears all of gd. Now that the cyclic list is a hlist, and
thus an empty list is represented by a NULL head pointer, and struct
cyclic_drv has no other members, we can just as well drop a level of
indirection and put the hlist_head directly in struct
global_data. This doesn't increase the size of struct global_data,
gets rid of an early malloc(), and generates slightly smaller code.
But primarily, this avoids having to call cyclic_init() early; the cyclic
infrastructure is simply ready to register callbacks as soon as we
enter C code.
We can still end up with schedule() being called from asm very early,
so we still need to check that gd itself has been properly initialized
[*], but once it has, gd->cyclic_list is perfectly fine to access, and
will just be an empty list.
As for cyclic_uninit(), it was never really the opposite of
cyclic_init() since it didn't free the struct cyclic_drv nor set
gd->cyclic to NULL. Rename it to cyclic_unregister_all() and use that
in test/, and also insert a call at the end of the board_init_f
sequence so that gd->cyclic_list is a fresh empty list before we enter
board_init_r().
A small piece of ugliness is that I had to add a cast in
cyclic_get_list() to silence a "discards 'volatile' qualifier"
warning, but that is completely equivalent to the existing handling of
the uclass_root_s list_head member.
[*] I'm not really sure where we guarantee that the register used for
gd contains 0 until it gets explicitly initialized, but that must be
the case, otherwise testing gd for being NULL would not make much sense.
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk >
Reviewed-by: Stefan Roese <sr@denx.de >
Tested-by: Stefan Roese <sr@denx.de >
Tested-by: Tim Harvey <tharvey@gateworks.com > # imx8mm-venice-*
2022-11-02 08:42:03 +01:00
2022-02-11 11:29:23 -05:00
2022-11-02 08:42:03 +01:00
2020-09-09 16:57:35 -04:00
2022-07-18 09:37:50 +01:00
2022-10-31 14:47:32 -04:00
2022-07-05 14:37:16 +02:00
2022-10-31 14:47:32 -04:00
2022-10-24 10:04:30 -04:00
2022-06-06 18:01:21 -04:00
2021-12-27 16:20:18 -05:00
2021-11-09 17:18:06 +05:30
2022-03-15 17:43:11 +08:00
2022-11-02 08:41:49 +01:00
2022-08-04 16:18:47 -04:00
2022-01-20 14:46:03 +01:00
2022-01-19 18:11:34 +01:00
2022-07-11 14:58:57 -04:00
2022-01-19 18:11:34 +01:00
2022-10-30 20:07:16 +01:00
2022-01-19 18:11:34 +01:00
2022-09-29 16:07:57 -04:00
2022-10-31 11:02:44 -04:00
2022-07-21 10:14:04 +02:00
2022-09-19 17:45:51 +02:00
2022-04-11 10:00:30 -04:00
2020-10-23 09:16:01 -04:00
2022-09-24 10:47:01 -04:00
2022-01-19 18:11:34 +01:00
2020-12-13 16:51:08 -07:00
2022-07-26 02:30:56 -06:00
2022-01-19 18:11:34 +01:00
2020-10-09 17:53:12 +08:00
2022-01-19 18:11:34 +01:00
2020-05-11 10:16:49 +05:30
2021-03-19 10:36:06 -04:00
2021-01-15 14:36:12 -05:00
2022-04-08 09:05:19 -04:00
2022-02-09 09:16:47 -05:00
2020-12-04 16:09:06 -05:00
2020-12-13 16:51:09 -07:00
2022-07-21 10:14:04 +02:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2020-08-24 14:11:13 -04:00
2021-02-02 15:33:42 -05:00
2022-01-30 01:25:00 +00:00
2022-01-30 01:25:00 +00:00
2022-01-30 01:25:00 +00:00
2022-01-30 01:25:00 +00:00
2022-01-30 01:25:00 +00:00
2022-01-30 01:25:00 +00:00
2021-10-25 14:50:42 +01:00
2022-01-19 18:11:34 +01:00
2021-01-31 14:08:56 +01:00
2022-06-28 03:09:52 +01:00
2022-01-19 18:11:34 +01:00
2022-08-12 08:14:23 -04:00
2020-05-18 21:19:23 -04:00
2022-10-31 11:02:44 -04:00
2022-10-31 11:04:00 -04:00
2022-01-19 18:11:34 +01:00
2022-07-07 14:01:09 -04:00
2022-04-25 10:00:04 -04:00
2022-10-31 11:02:44 -04:00
2022-09-29 16:07:57 -04:00
2022-08-12 08:17:11 -04:00
2022-01-19 18:11:34 +01:00
2022-10-31 11:03:18 -04:00
2022-08-12 08:17:11 -04:00
2020-04-22 20:41:56 +08:00
2022-07-21 10:14:04 +02:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2022-04-06 14:01:42 -04:00
2022-05-28 10:59:27 +02:00
2022-01-19 18:11:34 +01:00
2022-03-30 13:02:55 -04:00
2022-10-20 08:58:25 -04:00
2021-12-27 16:20:18 -05:00
2022-08-11 08:47:20 -04:00
2022-08-10 13:46:55 -04:00
2022-01-19 18:11:34 +01:00
2022-09-19 16:07:12 -04:00
2022-06-06 12:09:06 -04:00
2022-07-05 17:04:15 -04:00
2020-04-28 15:57:58 -04:00
2022-04-01 10:28:45 -04:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2021-02-02 15:33:42 -05:00
2022-04-06 14:01:42 -04:00
2022-01-19 18:11:34 +01:00
2021-01-30 14:25:42 -07:00
2022-11-02 08:42:03 +01:00
2020-07-08 17:21:46 -04:00
2022-02-11 11:29:23 -05:00
2022-08-10 13:46:55 -04:00
2022-01-19 18:11:34 +01:00
2022-04-25 10:00:04 -04:00
2021-09-30 09:08:16 -04:00
2020-08-03 22:19:54 -04:00
2020-08-03 22:19:54 -04:00
2022-10-18 13:40:40 -04:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2021-09-25 09:46:15 -06:00
2020-12-09 10:57:50 +01:00
2020-05-29 18:13:19 +08:00
2022-01-19 18:11:34 +01:00
2020-01-16 13:16:25 +08:00
2021-01-30 14:25:41 -07:00
2022-01-19 18:11:34 +01:00
2021-08-30 14:10:06 -04:00
2022-09-03 10:13:26 +02:00
2022-09-14 08:43:32 +02:00
2022-06-12 09:17:54 +02:00
2022-10-06 22:54:58 +02:00
2022-01-19 16:16:33 +01:00
2021-10-21 03:46:04 +02:00
2022-10-16 12:23:22 +02:00
2022-01-29 10:23:40 +01:00
2022-01-19 16:16:33 +01:00
2022-09-09 16:07:54 +02:00
2022-01-19 16:16:33 +01:00
2021-10-25 21:13:06 +02:00
2022-10-06 22:54:58 +02:00
2022-06-17 14:12:27 +02:00
2022-10-30 20:07:17 +01:00
2022-06-28 17:11:49 -04:00
2020-07-31 10:13:00 -04:00
2022-04-21 09:08:40 -04:00
2022-01-19 18:11:34 +01:00
2022-03-15 16:19:29 -04:00
2022-04-06 14:01:42 -04:00
2020-08-03 22:19:54 -04:00
2022-03-10 08:28:36 -05:00
2022-10-31 14:47:32 -04:00
2020-05-18 18:36:55 -04:00
2022-04-10 08:44:13 +03:00
2020-05-18 17:33:33 -04:00
2021-02-02 15:33:42 -05:00
2022-01-19 18:11:34 +01:00
2021-02-26 15:30:55 +01:00
2021-01-23 07:56:53 +01:00
2020-05-18 17:33:33 -04:00
2022-01-19 18:11:34 +01:00
2021-11-30 16:43:28 +01:00
2022-10-29 07:36:33 -06:00
2022-02-16 14:19:29 -05:00
2022-08-04 16:18:47 -04:00
2022-04-10 08:44:13 +03:00
2022-07-26 09:34:21 +02:00
2022-07-21 10:14:04 +02:00
2020-12-13 16:51:09 -07:00
2022-08-31 12:16:01 -04:00
2022-10-18 09:32:53 +08:00
2022-01-19 18:11:34 +01:00
2022-08-12 16:10:49 -04:00
2021-07-07 19:52:22 -04:00
2022-03-16 16:40:56 +09:00
2022-04-26 17:18:39 +05:30
2021-03-23 15:27:08 +05:30
2022-07-26 11:29:00 +02:00
2020-09-24 08:27:44 -04:00
2022-01-15 18:53:16 +02:00
2021-09-30 09:08:16 -04:00
2022-07-05 17:04:00 -04:00
2022-05-19 21:39:36 +02:00
2022-07-05 17:04:00 -04:00
2020-05-18 18:36:55 -04:00
2021-09-30 09:08:16 -04:00
2022-06-23 12:58:18 -04:00
2022-10-31 14:47:32 -04:00
2022-10-31 14:47:32 -04:00
2020-05-14 09:02:12 +02:00
2021-04-10 08:04:42 -04:00
2022-10-10 18:08:18 +02:00
2020-10-30 10:56:11 -04:00
2022-04-12 15:36:17 +02:00
2022-01-12 14:21:24 -05:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2020-01-24 23:06:49 +05:30
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2021-06-08 11:39:09 -04:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2022-06-08 13:59:53 -04:00
2022-07-05 17:03:01 -04:00
2022-01-19 18:11:34 +01:00
2021-08-30 14:13:28 -04:00
2022-06-28 17:03:32 -04:00
2021-02-02 15:33:42 -05:00
2022-10-31 11:02:45 -04:00
2022-07-26 11:29:02 +02:00
2022-07-26 11:29:01 +02:00
2022-07-25 15:35:34 +02:00
2022-10-06 21:05:17 -04:00
2021-02-02 15:33:42 -05:00
2022-01-19 18:11:34 +01:00
2021-10-31 08:46:44 -04:00
2022-04-19 14:52:34 -04:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2022-06-10 13:37:32 -04:00
2022-04-04 19:02:04 -04:00
2022-06-10 13:37:32 -04:00
2022-01-19 18:11:34 +01:00
2022-01-18 08:31:02 -05:00
2022-04-28 09:26:44 -04:00
2020-04-17 12:32:36 -04:00
2022-10-30 20:07:17 +01:00
2022-06-23 12:58:18 -04:00
2022-08-10 13:38:30 -04:00
2022-09-29 16:07:57 -04:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2022-09-29 16:07:58 -04:00
2021-09-30 09:08:16 -04:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2022-09-14 08:43:31 +02:00
2020-05-01 13:46:22 +02:00
2022-05-04 07:05:51 +02:00
2020-10-18 10:36:05 +02:00
2022-01-24 10:35:10 -05:00
2020-11-29 05:18:37 +01:00
2022-09-16 11:05:16 -04:00
2022-08-20 22:45:00 -04:00
2022-06-06 12:09:12 -04:00
2022-01-12 14:21:24 -05:00
2021-09-28 12:03:20 -04:00
2020-10-28 11:48:32 -04:00
2021-07-23 07:13:25 -04:00
2021-04-08 08:50:52 +02:00
2021-09-30 09:08:16 -04:00
2022-10-09 10:42:26 +02:00
2021-12-27 16:20:18 -05:00
2022-10-21 16:04:39 -04:00
2022-08-08 10:50:20 -04:00
2022-01-19 18:11:34 +01:00
2022-06-08 14:00:22 -04:00
2022-08-12 08:14:23 -04:00
2020-09-15 18:51:53 +05:30
2022-10-24 11:10:21 +02:00
2022-01-19 18:11:34 +01:00
2021-02-21 06:08:00 +01:00
2022-01-19 18:11:34 +01:00
2021-01-16 14:49:09 -05:00
2022-10-31 11:02:44 -04:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2022-03-25 13:35:50 -04:00
2022-01-19 18:11:34 +01:00
2022-10-29 07:36:33 -06:00
2022-05-23 13:52:02 -04:00
2021-02-10 10:00:51 +01:00
2022-01-19 18:11:34 +01:00
2022-10-21 16:04:39 -04:00
2021-02-18 11:56:25 +01:00
2022-01-19 18:11:34 +01:00
2021-07-07 19:52:24 -04:00
2020-02-05 19:33:46 -07:00
2022-04-21 12:44:23 +02:00
2020-08-14 15:18:30 -04:00
2022-01-19 18:11:34 +01:00
2022-02-11 09:00:47 -05:00
2021-04-12 17:44:55 -04:00
2022-01-19 18:11:34 +01:00
2020-06-14 21:07:20 +02:00
2022-07-08 12:20:28 -04:00
2020-05-18 17:33:33 -04:00
2022-01-19 18:11:34 +01:00
2022-02-08 11:00:03 -05:00
2020-02-05 19:33:46 -07:00
2022-01-19 18:11:34 +01:00
2020-06-14 21:07:20 +02:00
2022-05-05 15:06:02 -04:00
2020-08-24 11:03:26 +02:00
2022-04-23 22:05:33 +02:00
2020-05-18 17:33:33 -04:00
2022-06-23 13:12:55 -04:00
2022-06-23 13:12:55 -04:00
2022-03-02 17:42:06 -05:00
2021-03-13 13:14:52 -05:00
2022-10-31 11:02:44 -04:00
2022-10-31 11:02:44 -04:00
2022-10-24 18:01:23 +09:00
2022-01-20 11:35:29 +01:00
2022-01-19 18:11:34 +01:00
2022-04-01 16:56:53 -04:00
2022-04-01 15:03:13 -04:00
2022-09-24 11:34:37 -04:00
2020-12-31 14:41:31 +01:00
2022-02-28 11:59:35 +05:30
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2021-02-02 15:33:42 -05:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2022-05-23 09:33:10 -04:00
2022-09-13 12:08:40 -04:00
2022-10-16 12:23:22 +02:00
2022-01-19 18:11:34 +01:00
2022-10-31 11:04:00 -04:00
2021-12-26 23:33:24 +01:00
2020-11-19 09:45:49 -05:00
2021-09-30 08:08:56 -04:00
2022-04-06 14:03:17 -04:00
2022-09-24 10:47:01 -04:00
2022-09-24 10:47:01 -04:00
2020-12-09 10:57:50 +01:00
2022-04-04 23:24:17 +01:00
2022-01-19 18:11:34 +01:00
2021-05-04 07:57:18 -04:00
2021-11-04 08:57:19 +01:00
2022-06-06 12:09:28 -04:00
2022-04-14 15:39:15 -04:00
2021-12-31 06:44:29 +01:00
2020-08-03 22:19:54 -04:00
2021-01-31 14:08:56 +01:00
2022-09-13 16:01:43 -04:00
2020-10-22 09:54:53 -04:00
2021-04-06 16:33:19 +12:00
2022-01-19 18:11:34 +01:00
2022-09-03 16:53:58 +03:00
2022-09-03 16:59:05 +03:00
2022-01-19 18:11:34 +01:00
2022-09-03 16:59:05 +03:00
2022-01-19 18:11:34 +01:00
2022-01-19 18:11:34 +01:00
2021-11-23 09:57:55 +02:00
2021-02-21 06:08:00 +01:00
2021-02-21 06:08:00 +01:00
2020-05-18 17:33:33 -04:00
2020-01-17 10:15:49 -05:00
2022-01-19 18:11:34 +01:00
2022-07-12 21:59:54 +02:00
2022-01-19 18:11:34 +01:00
2020-09-01 14:47:43 +02:00
2022-02-11 00:03:48 +01:00
2021-01-31 14:08:56 +01:00
2021-01-27 17:03:16 -05:00
2022-10-31 11:04:00 -04:00
2022-07-26 09:34:21 +02:00
2021-09-17 12:10:44 -04:00
2021-09-17 12:10:44 -04:00
2022-08-12 08:14:23 -04:00
2022-01-19 18:11:34 +01:00
2022-10-30 20:01:40 +01:00
2021-09-30 09:08:16 -04:00
2021-02-22 20:06:43 +01:00
2022-01-19 18:11:34 +01:00
2022-10-30 20:07:16 +01:00
2022-06-08 09:24:03 -04:00
2022-01-19 18:11:34 +01:00
2022-04-10 08:44:13 +03:00
2022-04-25 10:00:03 -04:00
2020-05-18 18:36:55 -04:00
2021-05-13 13:09:09 -04:00
2021-05-13 13:09:09 -04:00
2022-09-18 10:26:33 +02:00
2022-09-18 10:26:49 +02:00
2022-01-19 18:11:34 +01:00
2021-01-15 14:36:12 -05:00
2022-07-26 09:34:21 +02:00
2020-05-18 21:19:23 -04:00
2020-06-23 14:43:23 -04:00
2022-07-26 08:36:20 +02:00
2022-07-26 09:34:21 +02:00
2020-06-24 13:07:57 +02:00
50128aeb0f