mirror of
				https://xff.cz/git/u-boot/
				synced 2025-10-31 18:35:42 +01:00 
			
		
		
		
	U-Boot widely uses error() as a bit noisier variant of printf(). This macro causes name conflict with the following line in include/linux/compiler-gcc.h: # define __compiletime_error(message) __attribute__((error(message))) This prevents us from using __compiletime_error(), and makes it difficult to fully sync BUILD_BUG macros with Linux. (Notice Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().) Let's convert error() into now treewide-available pr_err(). Done with the help of Coccinelle, excluing tools/ directory. The semantic patch I used is as follows: // <smpl> @@@@ -error +pr_err (...) // </smpl> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: Simon Glass <sjg@chromium.org> [trini: Re-run Coccinelle] Signed-off-by: Tom Rini <trini@konsulko.com>
		
			
				
	
	
		
			165 lines
		
	
	
		
			3.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			165 lines
		
	
	
		
			3.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * Copyright (C) 2015 Alexey Brodkin <abrodkin@synopsys.com>
 | |
|  *
 | |
|  * SPDX-License-Identifier:	GPL-2.0+
 | |
|  */
 | |
| 
 | |
| #include <common.h>
 | |
| #include <clk.h>
 | |
| #include <dm.h>
 | |
| #include <dm/ofnode.h>
 | |
| #include <generic-phy.h>
 | |
| #include <reset.h>
 | |
| #include "ohci.h"
 | |
| 
 | |
| #if !defined(CONFIG_USB_OHCI_NEW)
 | |
| # error "Generic OHCI driver requires CONFIG_USB_OHCI_NEW"
 | |
| #endif
 | |
| 
 | |
| struct generic_ohci {
 | |
| 	ohci_t ohci;
 | |
| 	struct clk *clocks;	/* clock list */
 | |
| 	struct reset_ctl *resets; /* reset list */
 | |
| 	struct phy phy;
 | |
| 	int clock_count;	/* number of clock in clock list */
 | |
| 	int reset_count;	/* number of reset in reset list */
 | |
| };
 | |
| 
 | |
| static int ohci_usb_probe(struct udevice *dev)
 | |
| {
 | |
| 	struct ohci_regs *regs = (struct ohci_regs *)devfdt_get_addr(dev);
 | |
| 	struct generic_ohci *priv = dev_get_priv(dev);
 | |
| 	int i, err, ret, clock_nb, reset_nb;
 | |
| 
 | |
| 	err = 0;
 | |
| 	priv->clock_count = 0;
 | |
| 	clock_nb = dev_count_phandle_with_args(dev, "clocks", "#clock-cells");
 | |
| 	if (clock_nb > 0) {
 | |
| 		priv->clocks = devm_kcalloc(dev, clock_nb, sizeof(struct clk),
 | |
| 					    GFP_KERNEL);
 | |
| 		if (!priv->clocks)
 | |
| 			return -ENOMEM;
 | |
| 
 | |
| 		for (i = 0; i < clock_nb; i++) {
 | |
| 			err = clk_get_by_index(dev, i, &priv->clocks[i]);
 | |
| 			if (err < 0)
 | |
| 				break;
 | |
| 
 | |
| 			err = clk_enable(&priv->clocks[i]);
 | |
| 			if (err) {
 | |
| 				pr_err("failed to enable clock %d\n", i);
 | |
| 				clk_free(&priv->clocks[i]);
 | |
| 				goto clk_err;
 | |
| 			}
 | |
| 			priv->clock_count++;
 | |
| 		}
 | |
| 	} else if (clock_nb != -ENOENT) {
 | |
| 		pr_err("failed to get clock phandle(%d)\n", clock_nb);
 | |
| 		return clock_nb;
 | |
| 	}
 | |
| 
 | |
| 	priv->reset_count = 0;
 | |
| 	reset_nb = dev_count_phandle_with_args(dev, "resets", "#reset-cells");
 | |
| 	if (reset_nb > 0) {
 | |
| 		priv->resets = devm_kcalloc(dev, reset_nb,
 | |
| 					    sizeof(struct reset_ctl),
 | |
| 					    GFP_KERNEL);
 | |
| 		if (!priv->resets)
 | |
| 			return -ENOMEM;
 | |
| 
 | |
| 		for (i = 0; i < reset_nb; i++) {
 | |
| 			err = reset_get_by_index(dev, i, &priv->resets[i]);
 | |
| 			if (err < 0)
 | |
| 				break;
 | |
| 
 | |
| 			err = reset_deassert(&priv->resets[i]);
 | |
| 			if (err) {
 | |
| 				pr_err("failed to deassert reset %d\n", i);
 | |
| 				reset_free(&priv->resets[i]);
 | |
| 				goto reset_err;
 | |
| 			}
 | |
| 			priv->reset_count++;
 | |
| 		}
 | |
| 	} else if (reset_nb != -ENOENT) {
 | |
| 		pr_err("failed to get reset phandle(%d)\n", reset_nb);
 | |
| 		goto clk_err;
 | |
| 	}
 | |
| 
 | |
| 	err = generic_phy_get_by_index(dev, 0, &priv->phy);
 | |
| 	if (err) {
 | |
| 		if (err != -ENOENT) {
 | |
| 			pr_err("failed to get usb phy\n");
 | |
| 			goto reset_err;
 | |
| 		}
 | |
| 	} else {
 | |
| 
 | |
| 		err = generic_phy_init(&priv->phy);
 | |
| 		if (err) {
 | |
| 			pr_err("failed to init usb phy\n");
 | |
| 			goto reset_err;
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	err = ohci_register(dev, regs);
 | |
| 	if (err)
 | |
| 		goto phy_err;
 | |
| 
 | |
| 	return 0;
 | |
| 
 | |
| phy_err:
 | |
| 	if (generic_phy_valid(&priv->phy)) {
 | |
| 		ret = generic_phy_exit(&priv->phy);
 | |
| 		if (ret)
 | |
| 			pr_err("failed to release phy\n");
 | |
| 	}
 | |
| 
 | |
| reset_err:
 | |
| 	ret = reset_release_all(priv->resets, priv->reset_count);
 | |
| 	if (ret)
 | |
| 		pr_err("failed to assert all resets\n");
 | |
| clk_err:
 | |
| 	ret = clk_release_all(priv->clocks, priv->clock_count);
 | |
| 	if (ret)
 | |
| 		pr_err("failed to disable all clocks\n");
 | |
| 
 | |
| 	return err;
 | |
| }
 | |
| 
 | |
| static int ohci_usb_remove(struct udevice *dev)
 | |
| {
 | |
| 	struct generic_ohci *priv = dev_get_priv(dev);
 | |
| 	int ret;
 | |
| 
 | |
| 	ret = ohci_deregister(dev);
 | |
| 	if (ret)
 | |
| 		return ret;
 | |
| 
 | |
| 	if (generic_phy_valid(&priv->phy)) {
 | |
| 		ret = generic_phy_exit(&priv->phy);
 | |
| 		if (ret)
 | |
| 			return ret;
 | |
| 	}
 | |
| 
 | |
| 	ret = reset_release_all(priv->resets, priv->reset_count);
 | |
| 	if (ret)
 | |
| 		return ret;
 | |
| 
 | |
| 	return clk_release_all(priv->clocks, priv->clock_count);
 | |
| }
 | |
| 
 | |
| static const struct udevice_id ohci_usb_ids[] = {
 | |
| 	{ .compatible = "generic-ohci" },
 | |
| 	{ }
 | |
| };
 | |
| 
 | |
| U_BOOT_DRIVER(ohci_generic) = {
 | |
| 	.name	= "ohci_generic",
 | |
| 	.id	= UCLASS_USB,
 | |
| 	.of_match = ohci_usb_ids,
 | |
| 	.probe = ohci_usb_probe,
 | |
| 	.remove = ohci_usb_remove,
 | |
| 	.ops	= &ohci_usb_ops,
 | |
| 	.priv_auto_alloc_size = sizeof(struct generic_ohci),
 | |
| 	.flags	= DM_FLAG_ALLOC_PRIV_DMA,
 | |
| };
 |