mirror of
				https://xff.cz/git/u-boot/
				synced 2025-10-31 10:26:10 +01:00 
			
		
		
		
	The 'get_phy_driver' code in 'drivers/net/phy/phy.c' uses the following
method to determine which driver is to be loaded for a particular PHY
module:
list_for_each(entry, &phy_drivers) {
	drv = list_entry(entry, struct phy_driver, list);
	if ((drv->uid & drv->mask) == (phy_id & drv->mask))
		return drv;
}
This means that a drv->mask of 0xfffff0 will return incorrect phy driver
for the logic above, even if the drv->uid is anything other than
something ending with a 0x0.
For e.g. if the RTL8211E drv->uid is 0x1cc915 and drv->mask is 0xffffff
and the RTL8211B drv->uid is 0x1cc910 and drv->mask is 0xffffff0, then
the phy driver selected will always be RTL8211B even though the
underlying phy connected on the board is a 8211E module.
This patch fixes this issue.
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
		
	
		
			
				
	
	
		
			142 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			142 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * RealTek PHY drivers
 | |
|  *
 | |
|  * SPDX-License-Identifier:	GPL-2.0+
 | |
|  *
 | |
|  * Copyright 2010-2011 Freescale Semiconductor, Inc.
 | |
|  * author Andy Fleming
 | |
|  */
 | |
| #include <config.h>
 | |
| #include <common.h>
 | |
| #include <phy.h>
 | |
| 
 | |
| #define PHY_AUTONEGOTIATE_TIMEOUT 5000
 | |
| 
 | |
| /* RTL8211x PHY Status Register */
 | |
| #define MIIM_RTL8211x_PHY_STATUS       0x11
 | |
| #define MIIM_RTL8211x_PHYSTAT_SPEED    0xc000
 | |
| #define MIIM_RTL8211x_PHYSTAT_GBIT     0x8000
 | |
| #define MIIM_RTL8211x_PHYSTAT_100      0x4000
 | |
| #define MIIM_RTL8211x_PHYSTAT_DUPLEX   0x2000
 | |
| #define MIIM_RTL8211x_PHYSTAT_SPDDONE  0x0800
 | |
| #define MIIM_RTL8211x_PHYSTAT_LINK     0x0400
 | |
| 
 | |
| 
 | |
| /* RealTek RTL8211x */
 | |
| static int rtl8211x_config(struct phy_device *phydev)
 | |
| {
 | |
| 	phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR, BMCR_RESET);
 | |
| 
 | |
| 	genphy_config_aneg(phydev);
 | |
| 
 | |
| 	return 0;
 | |
| }
 | |
| 
 | |
| static int rtl8211x_parse_status(struct phy_device *phydev)
 | |
| {
 | |
| 	unsigned int speed;
 | |
| 	unsigned int mii_reg;
 | |
| 
 | |
| 	mii_reg = phy_read(phydev, MDIO_DEVAD_NONE, MIIM_RTL8211x_PHY_STATUS);
 | |
| 
 | |
| 	if (!(mii_reg & MIIM_RTL8211x_PHYSTAT_SPDDONE)) {
 | |
| 		int i = 0;
 | |
| 
 | |
| 		/* in case of timeout ->link is cleared */
 | |
| 		phydev->link = 1;
 | |
| 		puts("Waiting for PHY realtime link");
 | |
| 		while (!(mii_reg & MIIM_RTL8211x_PHYSTAT_SPDDONE)) {
 | |
| 			/* Timeout reached ? */
 | |
| 			if (i > PHY_AUTONEGOTIATE_TIMEOUT) {
 | |
| 				puts(" TIMEOUT !\n");
 | |
| 				phydev->link = 0;
 | |
| 				break;
 | |
| 			}
 | |
| 
 | |
| 			if ((i++ % 1000) == 0)
 | |
| 				putc('.');
 | |
| 			udelay(1000);	/* 1 ms */
 | |
| 			mii_reg = phy_read(phydev, MDIO_DEVAD_NONE,
 | |
| 					MIIM_RTL8211x_PHY_STATUS);
 | |
| 		}
 | |
| 		puts(" done\n");
 | |
| 		udelay(500000);	/* another 500 ms (results in faster booting) */
 | |
| 	} else {
 | |
| 		if (mii_reg & MIIM_RTL8211x_PHYSTAT_LINK)
 | |
| 			phydev->link = 1;
 | |
| 		else
 | |
| 			phydev->link = 0;
 | |
| 	}
 | |
| 
 | |
| 	if (mii_reg & MIIM_RTL8211x_PHYSTAT_DUPLEX)
 | |
| 		phydev->duplex = DUPLEX_FULL;
 | |
| 	else
 | |
| 		phydev->duplex = DUPLEX_HALF;
 | |
| 
 | |
| 	speed = (mii_reg & MIIM_RTL8211x_PHYSTAT_SPEED);
 | |
| 
 | |
| 	switch (speed) {
 | |
| 	case MIIM_RTL8211x_PHYSTAT_GBIT:
 | |
| 		phydev->speed = SPEED_1000;
 | |
| 		break;
 | |
| 	case MIIM_RTL8211x_PHYSTAT_100:
 | |
| 		phydev->speed = SPEED_100;
 | |
| 		break;
 | |
| 	default:
 | |
| 		phydev->speed = SPEED_10;
 | |
| 	}
 | |
| 
 | |
| 	return 0;
 | |
| }
 | |
| 
 | |
| static int rtl8211x_startup(struct phy_device *phydev)
 | |
| {
 | |
| 	/* Read the Status (2x to make sure link is right) */
 | |
| 	genphy_update_link(phydev);
 | |
| 	rtl8211x_parse_status(phydev);
 | |
| 
 | |
| 	return 0;
 | |
| }
 | |
| 
 | |
| /* Support for RTL8211B PHY */
 | |
| static struct phy_driver RTL8211B_driver = {
 | |
| 	.name = "RealTek RTL8211B",
 | |
| 	.uid = 0x1cc910,
 | |
| 	.mask = 0xffffff,
 | |
| 	.features = PHY_GBIT_FEATURES,
 | |
| 	.config = &rtl8211x_config,
 | |
| 	.startup = &rtl8211x_startup,
 | |
| 	.shutdown = &genphy_shutdown,
 | |
| };
 | |
| 
 | |
| /* Support for RTL8211E-VB-CG, RTL8211E-VL-CG and RTL8211EG-VB-CG PHYs */
 | |
| static struct phy_driver RTL8211E_driver = {
 | |
| 	.name = "RealTek RTL8211E",
 | |
| 	.uid = 0x1cc915,
 | |
| 	.mask = 0xffffff,
 | |
| 	.features = PHY_GBIT_FEATURES,
 | |
| 	.config = &rtl8211x_config,
 | |
| 	.startup = &rtl8211x_startup,
 | |
| 	.shutdown = &genphy_shutdown,
 | |
| };
 | |
| 
 | |
| /* Support for RTL8211DN PHY */
 | |
| static struct phy_driver RTL8211DN_driver = {
 | |
| 	.name = "RealTek RTL8211DN",
 | |
| 	.uid = 0x1cc914,
 | |
| 	.mask = 0xffffff,
 | |
| 	.features = PHY_GBIT_FEATURES,
 | |
| 	.config = &rtl8211x_config,
 | |
| 	.startup = &rtl8211x_startup,
 | |
| 	.shutdown = &genphy_shutdown,
 | |
| };
 | |
| 
 | |
| int phy_realtek_init(void)
 | |
| {
 | |
| 	phy_register(&RTL8211B_driver);
 | |
| 	phy_register(&RTL8211E_driver);
 | |
| 	phy_register(&RTL8211DN_driver);
 | |
| 
 | |
| 	return 0;
 | |
| }
 |