mirror of
https://xff.cz/git/u-boot/
synced 2025-09-03 17:52:07 +02:00
buildman: Make -I the default
At present buildman defaults to running 'mrproper' on every thread before it starts building commits for each board. This can add a delay of about 5 seconds to the start of the process, since the tools and other invariants must be rebuilt. In particular, a build without '-b', to build current source, runs much slower without -I, since any existing build is removed, thus losing the possibility of an incremental build. Partly this behaviour was to avoid strange build-system problems caused by running 'make defconfig' for one board and then one with a different architecture. But these problems were fixed quite a while ago. The -I option (which disabled mrproper) was introduced four years ago and does not seem to cause any problems with builds. So make -I the default and deprecate the option. To allow use of 'mrproper', add a new -m flag. Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
@@ -90,12 +90,12 @@ class BuilderThread(threading.Thread):
|
||||
thread_num: Our thread number (0-n-1), used to decide on a
|
||||
temporary directory
|
||||
"""
|
||||
def __init__(self, builder, thread_num, incremental, per_board_out_dir):
|
||||
def __init__(self, builder, thread_num, mrproper, per_board_out_dir):
|
||||
"""Set up a new builder thread"""
|
||||
threading.Thread.__init__(self)
|
||||
self.builder = builder
|
||||
self.thread_num = thread_num
|
||||
self.incremental = incremental
|
||||
self.mrproper = mrproper
|
||||
self.per_board_out_dir = per_board_out_dir
|
||||
|
||||
def Make(self, commit, brd, stage, cwd, *args, **kwargs):
|
||||
@@ -243,7 +243,7 @@ class BuilderThread(threading.Thread):
|
||||
# If we need to reconfigure, do that now
|
||||
if do_config:
|
||||
config_out = ''
|
||||
if not self.incremental:
|
||||
if self.mrproper:
|
||||
result = self.Make(commit, brd, 'mrproper', cwd,
|
||||
'mrproper', *args, env=env)
|
||||
config_out += result.combined
|
||||
|
Reference in New Issue
Block a user