dany/u-boot-megous
1
0
Fork 0
mirror of https://xff.cz/git/u-boot/ synced 2025-09-29 22:41:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

cmd: sf Drop reassignment of new into flash

Browse Source 
The new pointer points to flash found and that would
assign it to global 'flash' pointer for further flash
operations and also keep track of old flash pointer.

This would happen if the probe is successful or even
failed, but current code assigning new into flash before
and after checking the new.

So, drop the assignment after new checks so flash always
latest new pointer even if probe failed or succeed.

Cc: Simon Glass <sjg@chromium.org>
Cc: Vignesh R <vigneshr@ti.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
This commit is contained in:
Jagan Teki
2020-05-13 16:28:01 +05:30
parent 46e4cdff1e
commit da37b539e6
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/sf.c
View File

@@ -145,13 +145,10 @@ static int do_spi_flash_probe(int argc, char *const argv[])
new = spi_flash_probe(bus, cs, speed, mode); new = spi_flash_probe(bus, cs, speed, mode);
flash = new; flash = new;
if (!new) { if (!new) {
printf("Failed to initialize SPI flash at %u:%u\n", bus, cs); printf("Failed to initialize SPI flash at %u:%u\n", bus, cs);
return 1; return 1;
} }
flash = new;
#endif #endif
return 0; return 0;