dany/u-boot-megous
1
0
Fork 0
mirror of https://xff.cz/git/u-boot/ synced 2025-10-28 09:03:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

tools: kwboot: Fix return type of kwboot_xm_makeblock() function

Browse Source 
Function kwboot_xm_makeblock() always returns length of xmodem block. It
is always non-negative and calculated from variable with size_t type. Set
return type of this function to size_t and remove dead code which checks
for negative value.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Stefan Roese <sr@denx.de>
This commit is contained in:
Pali Rohár
2021-09-24 23:06:44 +02:00
committed by Stefan Roese
parent 00a1deed1c
commit c5d666aab3
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tools/kwboot.c
View File

@@ -347,7 +347,7 @@ kwboot_debugmsg(int tty, void *msg)
return rc; return rc;
} }
static int static size_t
kwboot_xm_makeblock(struct kwboot_block *block, const void *data, kwboot_xm_makeblock(struct kwboot_block *block, const void *data,
size_t size, int pnum) size_t size, int pnum)
{ {
@@ -441,9 +441,6 @@ kwboot_xmodem(int tty, const void *_data, size_t size)
n = kwboot_xm_makeblock(&block, n = kwboot_xm_makeblock(&block,
data + N, size - N, data + N, size - N,
pnum++); pnum++);
if (n < 0)
goto can;
if (!n) if (!n)
break; break;