mirror of
				https://xff.cz/git/u-boot/
				synced 2025-10-31 10:26:10 +01:00 
			
		
		
		
	ddr: altera: sdram: Clean up sdram_mmr_init_full() part 1
Zap all the ad-hoc readbacks from the registers and other useless and broken debug output. This is really not useful and is only confusing. Signed-off-by: Marek Vasut <marex@denx.de>
This commit is contained in:
		| @@ -500,7 +500,6 @@ static void set_sdr_mp_threshold(struct socfpga_sdram_config *cfg) | |||||||
| /* Function to initialize SDRAM MMR */ | /* Function to initialize SDRAM MMR */ | ||||||
| unsigned sdram_mmr_init_full(unsigned int sdr_phy_reg) | unsigned sdram_mmr_init_full(unsigned int sdr_phy_reg) | ||||||
| { | { | ||||||
| 	unsigned long reg_value; |  | ||||||
| 	unsigned long status = 0; | 	unsigned long status = 0; | ||||||
| 	struct socfpga_sdram_config *cfg = &sdram_config; | 	struct socfpga_sdram_config *cfg = &sdram_config; | ||||||
|  |  | ||||||
| @@ -574,73 +573,36 @@ defined(CONFIG_HPS_SDR_CTRLCFG_DRAMADDRW_ROWBITS) | |||||||
| 			SDR_CTRLGRP_CPORTWIDTH_CMDPORTWIDTH_MASK, | 			SDR_CTRLGRP_CPORTWIDTH_CMDPORTWIDTH_MASK, | ||||||
| 			CONFIG_HPS_SDR_CTRLCFG_CPORTWIDTH_CPORTWIDTH << | 			CONFIG_HPS_SDR_CTRLCFG_CPORTWIDTH_CPORTWIDTH << | ||||||
| 			SDR_CTRLGRP_CPORTWIDTH_CMDPORTWIDTH_LSB); | 			SDR_CTRLGRP_CPORTWIDTH_CMDPORTWIDTH_LSB); | ||||||
| 	debug("   Write - Address "); |  | ||||||
| 	debug("0x%08x Data 0x%08x\n", |  | ||||||
| 		(unsigned)(&sdr_ctrl->cport_width), |  | ||||||
| 		(unsigned)reg_value); |  | ||||||
| 	reg_value = readl(&sdr_ctrl->cport_width); |  | ||||||
| 	debug("   Read value without verify 0x%08x\n", (unsigned)reg_value); |  | ||||||
|  |  | ||||||
| 	debug("Configuring CPORTWMAP\n"); | 	debug("Configuring CPORTWMAP\n"); | ||||||
| 	clrsetbits_le32(&sdr_ctrl->cport_wmap, | 	clrsetbits_le32(&sdr_ctrl->cport_wmap, | ||||||
| 			SDR_CTRLGRP_CPORTWMAP_CPORTWFIFOMAP_MASK, | 			SDR_CTRLGRP_CPORTWMAP_CPORTWFIFOMAP_MASK, | ||||||
| 			CONFIG_HPS_SDR_CTRLCFG_CPORTWMAP_CPORTWMAP << | 			CONFIG_HPS_SDR_CTRLCFG_CPORTWMAP_CPORTWMAP << | ||||||
| 			SDR_CTRLGRP_CPORTWMAP_CPORTWFIFOMAP_LSB); | 			SDR_CTRLGRP_CPORTWMAP_CPORTWFIFOMAP_LSB); | ||||||
| 	debug("   Write - Address "); |  | ||||||
| 	debug("0x%08x Data 0x%08x\n", |  | ||||||
| 		(unsigned)(&sdr_ctrl->cport_wmap), |  | ||||||
| 		(unsigned)reg_value); |  | ||||||
| 	reg_value = readl(&sdr_ctrl->cport_wmap); |  | ||||||
| 	debug("   Read value without verify 0x%08x\n", (unsigned)reg_value); |  | ||||||
|  |  | ||||||
| 	debug("Configuring CPORTRMAP\n"); | 	debug("Configuring CPORTRMAP\n"); | ||||||
| 	clrsetbits_le32(&sdr_ctrl->cport_rmap, | 	clrsetbits_le32(&sdr_ctrl->cport_rmap, | ||||||
| 			SDR_CTRLGRP_CPORTRMAP_CPORTRFIFOMAP_MASK, | 			SDR_CTRLGRP_CPORTRMAP_CPORTRFIFOMAP_MASK, | ||||||
| 			CONFIG_HPS_SDR_CTRLCFG_CPORTRMAP_CPORTRMAP << | 			CONFIG_HPS_SDR_CTRLCFG_CPORTRMAP_CPORTRMAP << | ||||||
| 			SDR_CTRLGRP_CPORTRMAP_CPORTRFIFOMAP_LSB); | 			SDR_CTRLGRP_CPORTRMAP_CPORTRFIFOMAP_LSB); | ||||||
| 	debug("   Write - Address "); |  | ||||||
| 	debug("0x%08x Data 0x%08x\n", |  | ||||||
| 		(unsigned)(&sdr_ctrl->cport_rmap), |  | ||||||
| 		(unsigned)reg_value); |  | ||||||
| 	reg_value = readl(&sdr_ctrl->cport_rmap); |  | ||||||
| 	debug("   Read value without verify 0x%08x\n", (unsigned)reg_value); |  | ||||||
|  |  | ||||||
| 	debug("Configuring RFIFOCMAP\n"); | 	debug("Configuring RFIFOCMAP\n"); | ||||||
| 	clrsetbits_le32(&sdr_ctrl->rfifo_cmap, | 	clrsetbits_le32(&sdr_ctrl->rfifo_cmap, | ||||||
| 			SDR_CTRLGRP_RFIFOCMAP_RFIFOCPORTMAP_MASK, | 			SDR_CTRLGRP_RFIFOCMAP_RFIFOCPORTMAP_MASK, | ||||||
| 			CONFIG_HPS_SDR_CTRLCFG_RFIFOCMAP_RFIFOCMAP << | 			CONFIG_HPS_SDR_CTRLCFG_RFIFOCMAP_RFIFOCMAP << | ||||||
| 			SDR_CTRLGRP_RFIFOCMAP_RFIFOCPORTMAP_LSB); | 			SDR_CTRLGRP_RFIFOCMAP_RFIFOCPORTMAP_LSB); | ||||||
| 	debug("   Write - Address "); |  | ||||||
| 	debug("0x%08x Data 0x%08x\n", |  | ||||||
| 		(unsigned)(&sdr_ctrl->rfifo_cmap), |  | ||||||
| 		(unsigned)reg_value); |  | ||||||
| 	reg_value = readl(&sdr_ctrl->rfifo_cmap); |  | ||||||
| 	debug("   Read value without verify 0x%08x\n", (unsigned)reg_value); |  | ||||||
|  |  | ||||||
| 	debug("Configuring WFIFOCMAP\n"); | 	debug("Configuring WFIFOCMAP\n"); | ||||||
| 	reg_value = readl(&sdr_ctrl->wfifo_cmap); |  | ||||||
| 	clrsetbits_le32(&sdr_ctrl->wfifo_cmap, | 	clrsetbits_le32(&sdr_ctrl->wfifo_cmap, | ||||||
| 			SDR_CTRLGRP_WFIFOCMAP_WFIFOCPORTMAP_MASK, | 			SDR_CTRLGRP_WFIFOCMAP_WFIFOCPORTMAP_MASK, | ||||||
| 			CONFIG_HPS_SDR_CTRLCFG_WFIFOCMAP_WFIFOCMAP << | 			CONFIG_HPS_SDR_CTRLCFG_WFIFOCMAP_WFIFOCMAP << | ||||||
| 			SDR_CTRLGRP_WFIFOCMAP_WFIFOCPORTMAP_LSB); | 			SDR_CTRLGRP_WFIFOCMAP_WFIFOCPORTMAP_LSB); | ||||||
| 	debug("   Write - Address "); |  | ||||||
| 	debug("0x%08x Data 0x%08x\n", |  | ||||||
| 		(unsigned)(&sdr_ctrl->wfifo_cmap), |  | ||||||
| 		(unsigned)reg_value); |  | ||||||
| 	reg_value = readl(&sdr_ctrl->wfifo_cmap); |  | ||||||
| 	debug("   Read value without verify 0x%08x\n", (unsigned)reg_value); |  | ||||||
|  |  | ||||||
| 	debug("Configuring CPORTRDWR\n"); | 	debug("Configuring CPORTRDWR\n"); | ||||||
| 	clrsetbits_le32(&sdr_ctrl->cport_rdwr, | 	clrsetbits_le32(&sdr_ctrl->cport_rdwr, | ||||||
| 			SDR_CTRLGRP_CPORTRDWR_CPORTRDWR_MASK, | 			SDR_CTRLGRP_CPORTRDWR_CPORTRDWR_MASK, | ||||||
| 			CONFIG_HPS_SDR_CTRLCFG_CPORTRDWR_CPORTRDWR << | 			CONFIG_HPS_SDR_CTRLCFG_CPORTRDWR_CPORTRDWR << | ||||||
| 			SDR_CTRLGRP_CPORTRDWR_CPORTRDWR_LSB); | 			SDR_CTRLGRP_CPORTRDWR_CPORTRDWR_LSB); | ||||||
| 	debug("   Write - Address "); |  | ||||||
| 	debug("0x%08x Data 0x%08x\n", |  | ||||||
| 		(unsigned)(&sdr_ctrl->cport_rdwr), |  | ||||||
| 		(unsigned)reg_value); |  | ||||||
| 	reg_value = readl(&sdr_ctrl->cport_rdwr); |  | ||||||
| 	debug("   Read value without verify 0x%08x\n", (unsigned)reg_value); |  | ||||||
|  |  | ||||||
| 	debug("Configuring DRAMODT\n"); | 	debug("Configuring DRAMODT\n"); | ||||||
| 	clrsetbits_le32(&sdr_ctrl->dram_odt, | 	clrsetbits_le32(&sdr_ctrl->dram_odt, | ||||||
| @@ -674,12 +636,6 @@ defined(CONFIG_HPS_SDR_CTRLCFG_DRAMADDRW_ROWBITS) | |||||||
| 	debug("Configuring STATICCFG_\n"); | 	debug("Configuring STATICCFG_\n"); | ||||||
| 	clrsetbits_le32(&sdr_ctrl->static_cfg, SDR_CTRLGRP_STATICCFG_APPLYCFG_MASK, | 	clrsetbits_le32(&sdr_ctrl->static_cfg, SDR_CTRLGRP_STATICCFG_APPLYCFG_MASK, | ||||||
| 			1 << SDR_CTRLGRP_STATICCFG_APPLYCFG_LSB); | 			1 << SDR_CTRLGRP_STATICCFG_APPLYCFG_LSB); | ||||||
| 	debug("   Write - Address "); |  | ||||||
| 	debug("0x%08x Data 0x%08x\n", |  | ||||||
| 		(unsigned)(&sdr_ctrl->static_cfg), |  | ||||||
| 		(unsigned)reg_value); |  | ||||||
| 	reg_value = readl(&sdr_ctrl->static_cfg); |  | ||||||
| 	debug("   Read value without verify 0x%08x\n", (unsigned)reg_value); |  | ||||||
|  |  | ||||||
| 	sdram_set_protection_config(0, sdram_calculate_size()); | 	sdram_set_protection_config(0, sdram_calculate_size()); | ||||||
|  |  | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user