dany/u-boot-megous
1
0
Fork 0
mirror of https://xff.cz/git/u-boot/ synced 2025-10-07 11:15:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

treewide: convert bd_t to struct bd_info by coccinelle

Browse Source 
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:

  It's a **mistake** to use typedef for structures and pointers.

Besides, using typedef for structures is annoying when you try to make
headers self-contained.

Let's say you have the following function declaration in a header:

  void foo(bd_t *bd);

This is not self-contained since bd_t is not defined.

To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>

  #include <asm/u-boot.h>
  void foo(bd_t *bd);

Then, the include direcective pulls in more bloat needlessly.

If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:

  struct bd_info;
  void foo(struct bd_info *bd);

Right, typedef'ing bd_t is a mistake.

I used coccinelle to generate this commit.

The semantic patch that makes this change is as follows:

  <smpl>
  @@
  typedef bd_t;
  @@
  -bd_t
  +struct bd_info
  </smpl>

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
Masahiro Yamada
2020-06-26 15:13:33 +09:00
committed by Tom Rini
parent 02ff91e8c6
commit b75d8dc564
489 changed files with 801 additions and 784 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
board/ti/evm/evm.c
View File

@@ -284,7 +284,7 @@ static void reset_net_chip(void)
gpio_set_value(rst_gpio, 1);
}
int board_eth_init(bd_t *bis)
int board_eth_init(struct bd_info *bis)
{
#if defined(CONFIG_SMC911X)
env_set("ethaddr", NULL);
@@ -296,7 +296,7 @@ int board_eth_init(bd_t *bis)
#endif /* CONFIG_CMD_NET */
#if defined(CONFIG_MMC)
int board_mmc_init(bd_t *bis)
int board_mmc_init(struct bd_info *bis)
{
return omap_mmc_init(0, 0, 0, -1, -1);
}
@@ -308,7 +308,7 @@ void board_mmc_power_init(void)
#endif /* CONFIG_MMC */
#if defined(CONFIG_USB_ETHER) && defined(CONFIG_USB_MUSB_GADGET) && !defined(CONFIG_CMD_NET)
int board_eth_init(bd_t *bis)
int board_eth_init(struct bd_info *bis)
{
return usb_eth_initialize(bis);
}