mirror of
https://xff.cz/git/u-boot/
synced 2025-09-28 14:01:16 +02:00
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
committed by
Tom Rini
parent
02ff91e8c6
commit
b75d8dc564
@@ -61,7 +61,7 @@ static int ts4600_mmc_cd(int id)
|
||||
return 1;
|
||||
}
|
||||
|
||||
int board_mmc_init(bd_t *bis)
|
||||
int board_mmc_init(struct bd_info *bis)
|
||||
{
|
||||
int ret;
|
||||
|
||||
|
@@ -121,7 +121,7 @@ int board_mmc_getcd(struct mmc *mmc)
|
||||
return ret;
|
||||
}
|
||||
|
||||
int board_mmc_init(bd_t *bis)
|
||||
int board_mmc_init(struct bd_info *bis)
|
||||
{
|
||||
static const iomux_v3_cfg_t sd1_pads[] = {
|
||||
NEW_PAD_CTRL(MX51_PAD_SD1_CMD__SD1_CMD, PAD_CTL_DSE_MAX |
|
||||
@@ -191,7 +191,7 @@ static int fec_get_mac_from_register(uint32_t base_addr)
|
||||
}
|
||||
|
||||
#define TS4800_GPIO_FEC_PHY_RES IMX_GPIO_NR(2, 14)
|
||||
int board_eth_init(bd_t *bd)
|
||||
int board_eth_init(struct bd_info *bd)
|
||||
{
|
||||
int dev_id = -1;
|
||||
int phy_id = 0xFF;
|
||||
|
Reference in New Issue
Block a user