mirror of
https://xff.cz/git/u-boot/
synced 2025-09-03 17:52:07 +02:00
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
committed by
Tom Rini
parent
02ff91e8c6
commit
b75d8dc564
@@ -80,7 +80,7 @@ static struct fsl_esdhc_cfg cl_som_imx7_usdhc_cfg[3] = {
|
||||
{USDHC3_BASE_ADDR},
|
||||
};
|
||||
|
||||
int board_mmc_init(bd_t *bis)
|
||||
int board_mmc_init(struct bd_info *bis)
|
||||
{
|
||||
int i, ret;
|
||||
/*
|
||||
@@ -199,7 +199,7 @@ static int cl_som_imx7_handle_mac_address(char *env_var, uint eeprom_bus)
|
||||
|
||||
#define CL_SOM_IMX7_FEC_DEV_ID_PRI 0
|
||||
|
||||
int board_eth_init(bd_t *bis)
|
||||
int board_eth_init(struct bd_info *bis)
|
||||
{
|
||||
/* set Ethernet MAC address environment */
|
||||
cl_som_imx7_handle_mac_address("ethaddr", CONFIG_SYS_I2C_EEPROM_BUS);
|
||||
|
@@ -23,7 +23,7 @@
|
||||
static struct fsl_esdhc_cfg cl_som_imx7_spl_usdhc_cfg = {
|
||||
USDHC1_BASE_ADDR, 0, 4};
|
||||
|
||||
int board_mmc_init(bd_t *bis)
|
||||
int board_mmc_init(struct bd_info *bis)
|
||||
{
|
||||
cl_som_imx7_usdhc1_pads_set();
|
||||
cl_som_imx7_spl_usdhc_cfg.sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK);
|
||||
|
@@ -458,7 +458,7 @@ static int handle_mac_address(char *env_var, uint eeprom_bus)
|
||||
|
||||
#define SB_FX6_I2C_EEPROM_BUS 0
|
||||
#define NO_MAC_ADDR "No MAC address found for %s\n"
|
||||
int board_eth_init(bd_t *bis)
|
||||
int board_eth_init(struct bd_info *bis)
|
||||
{
|
||||
int err;
|
||||
|
||||
@@ -537,7 +537,7 @@ static const struct node_info nodes[] = {
|
||||
{ "jedec,spi-nor", MTD_DEV_TYPE_NOR, },
|
||||
};
|
||||
|
||||
int ft_board_setup(void *blob, bd_t *bd)
|
||||
int ft_board_setup(void *blob, struct bd_info *bd)
|
||||
{
|
||||
u32 baseboard_rev;
|
||||
int nodeoffset;
|
||||
|
@@ -356,7 +356,7 @@ static struct fsl_esdhc_cfg usdhc_cfg = {
|
||||
.max_bus_width = 4,
|
||||
};
|
||||
|
||||
int board_mmc_init(bd_t *bis)
|
||||
int board_mmc_init(struct bd_info *bis)
|
||||
{
|
||||
cm_fx6_set_usdhc_iomux();
|
||||
|
||||
|
@@ -128,7 +128,7 @@ static int handle_mac_address(void)
|
||||
#define AR8051_DEBUG_RGMII_CLK_DLY_REG 0x5
|
||||
#define AR8051_RGMII_TX_CLK_DLY 0x100
|
||||
|
||||
int board_eth_init(bd_t *bis)
|
||||
int board_eth_init(struct bd_info *bis)
|
||||
{
|
||||
int rv, n = 0;
|
||||
const char *devname;
|
||||
|
@@ -149,7 +149,7 @@ static void board_phy_init(void)
|
||||
mdelay(2);
|
||||
}
|
||||
|
||||
int board_eth_init(bd_t *bis)
|
||||
int board_eth_init(struct bd_info *bis)
|
||||
{
|
||||
int rv;
|
||||
|
||||
|
Reference in New Issue
Block a user