dany/u-boot-megous
1
0
Fork 0
mirror of https://xff.cz/git/u-boot/ synced 2025-09-02 01:02:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

treewide: convert bd_t to struct bd_info by coccinelle

Browse Source 
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:

  It's a **mistake** to use typedef for structures and pointers.

Besides, using typedef for structures is annoying when you try to make
headers self-contained.

Let's say you have the following function declaration in a header:

  void foo(bd_t *bd);

This is not self-contained since bd_t is not defined.

To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>

  #include <asm/u-boot.h>
  void foo(bd_t *bd);

Then, the include direcective pulls in more bloat needlessly.

If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:

  struct bd_info;
  void foo(struct bd_info *bd);

Right, typedef'ing bd_t is a mistake.

I used coccinelle to generate this commit.

The semantic patch that makes this change is as follows:

  <smpl>
  @@
  typedef bd_t;
  @@
  -bd_t
  +struct bd_info
  </smpl>

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
Masahiro Yamada
2020-06-26 15:13:33 +09:00
committed by Tom Rini
parent 02ff91e8c6
commit b75d8dc564
489 changed files with 801 additions and 784 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
arch/m68k/cpu/mcf523x/cpu.c
View File

@@ -108,7 +108,7 @@ int watchdog_init(void)
* int board_eth_init(bd_t *bis)
*/
int cpu_eth_init(bd_t *bis)
int cpu_eth_init(struct bd_info *bis)
{
return mcffec_initialize(bis);
}

2
arch/m68k/cpu/mcf52x2/cpu.c
View File

@@ -423,7 +423,7 @@ int do_reset(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
* int board_eth_init(bd_t *bis)
*/
int cpu_eth_init(bd_t *bis)
int cpu_eth_init(struct bd_info *bis)
{
return mcffec_initialize(bis);
}

2
arch/m68k/cpu/mcf532x/cpu.c
View File

@@ -149,7 +149,7 @@ int watchdog_init(void)
* create a board-specific function called:
* int board_eth_init(bd_t *bis)
*/
int cpu_eth_init(bd_t *bis)
int cpu_eth_init(struct bd_info *bis)
{
return mcffec_initialize(bis);
}

2
arch/m68k/cpu/mcf5445x/cpu.c
View File

@@ -112,7 +112,7 @@ int print_cpuinfo(void)
* int board_eth_init(bd_t *bis)
*/
int cpu_eth_init(bd_t *bis)
int cpu_eth_init(struct bd_info *bis)
{
return mcffec_initialize(bis);
}

2
arch/m68k/cpu/mcf547x_8x/cpu.c
View File

@@ -139,7 +139,7 @@ int watchdog_init(void)
* int board_eth_init(bd_t *bis)
*/
int cpu_eth_init(bd_t *bis)
int cpu_eth_init(struct bd_info *bis)
{
#if defined(CONFIG_FSLDMAFEC)
mcdmafec_initialize(bis);

2
arch/m68k/lib/bdinfo.c
View File

@@ -13,7 +13,7 @@ DECLARE_GLOBAL_DATA_PTR;
void arch_print_bdinfo(void)
{
bd_t *bd = gd->bd;
struct bd_info *bd = gd->bd;
#if defined(CONFIG_SYS_INIT_RAM_ADDR)
bdinfo_print_num("sramstart", (ulong)bd->bi_sramstart);

10
arch/m68k/lib/bootm.c
View File

@@ -27,7 +27,7 @@ DECLARE_GLOBAL_DATA_PTR;
#define LINUX_MAX_ARGS 256
static ulong get_sp (void);
static void set_clocks_in_mhz (bd_t *kbd);
static void set_clocks_in_mhz (struct bd_info *kbd);
void arch_lmb_reserve(struct lmb *lmb)
{
@@ -54,8 +54,8 @@ int do_bootm_linux(int flag, int argc, char *const argv[],
bootm_headers_t *images)
{
int ret;
bd_t *kbd;
void (*kernel) (bd_t *, ulong, ulong, ulong, ulong);
struct bd_info *kbd;
void (*kernel) (struct bd_info *, ulong, ulong, ulong, ulong);
struct lmb *lmb = &images->lmb;
/*
@@ -79,7 +79,7 @@ int do_bootm_linux(int flag, int argc, char *const argv[],
if (ret)
goto error;
kernel = (void (*)(bd_t *, ulong, ulong, ulong, ulong))images->ep;
kernel = (void (*)(struct bd_info *, ulong, ulong, ulong, ulong))images->ep;
debug("## Transferring control to Linux (at address %08lx) ...\n",
(ulong) kernel);
@@ -112,7 +112,7 @@ static ulong get_sp (void)
return sp;
}
static void set_clocks_in_mhz (bd_t *kbd)
static void set_clocks_in_mhz (struct bd_info *kbd)
{
char *s;