dany/u-boot-megous
1
0
Fork 0
mirror of https://xff.cz/git/u-boot/ synced 2025-09-05 02:32:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

drivers: net: pfe_eth: undefined return value

Browse Source 
Do not use random value from stack as return value of pfe_phy_write().

Indicated by cppcheck.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
This commit is contained in:
Heinrich Schuchardt
2019-07-31 00:00:51 +02:00
committed by Joe Hershberger
parent fd6d88f55b
commit 9bbff5478e
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/pfe_eth/pfe_mdio.c
View File

@@ -110,7 +110,6 @@ static int pfe_phy_write(struct mii_dev *bus, int phy_addr, int dev_addr,
u32 phy; u32 phy;
u32 reg_data; u32 reg_data;
int timeout = MDIO_TIMEOUT; int timeout = MDIO_TIMEOUT;
int val;
if (dev_addr == MDIO_DEVAD_NONE) { if (dev_addr == MDIO_DEVAD_NONE) {
reg = ((reg_addr & EMAC_MII_DATA_RA_MASK) << reg = ((reg_addr & EMAC_MII_DATA_RA_MASK) <<
@@ -150,7 +149,7 @@ static int pfe_phy_write(struct mii_dev *bus, int phy_addr, int dev_addr,
debug("%s: phy: %02x reg:%02x val:%#x\n", __func__, phy_addr, debug("%s: phy: %02x reg:%02x val:%#x\n", __func__, phy_addr,
reg_addr, data); reg_addr, data);
return val; return 0;
} }
static void pfe_configure_serdes(struct pfe_eth_dev *priv) static void pfe_configure_serdes(struct pfe_eth_dev *priv)