mirror of
https://xff.cz/git/u-boot/
synced 2025-09-23 19:42:08 +02:00
cmd: ti: ddr3: Move the print statement after test
If the ECC is enabled over the entire memory region, we need to ensure the printf/put calls do not modify the stack after ECC is disabled. Moved the printf/put statements after ECC is enabled. Signed-off-by: Krunal Bhargav <k-bhargav@ti.com> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
This commit is contained in:
@@ -202,10 +202,6 @@ static int ddr_memory_ecc_err(u32 addr, u32 ecc_err)
|
|||||||
writel(val2, addr);
|
writel(val2, addr);
|
||||||
|
|
||||||
val3 = readl(addr);
|
val3 = readl(addr);
|
||||||
printf("\tECC test: addr 0x%x, read data 0x%x, written data 0x%x, err pattern: 0x%x, read after write data 0x%x\n",
|
|
||||||
addr, val1, val2, ecc_err, val3);
|
|
||||||
|
|
||||||
puts("\tECC test: Enabling DDR ECC ...\n");
|
|
||||||
#ifdef CONFIG_ARCH_KEYSTONE
|
#ifdef CONFIG_ARCH_KEYSTONE
|
||||||
ecc_ctrl = ECC_START_ADDR1 | (ECC_END_ADDR1 << 16);
|
ecc_ctrl = ECC_START_ADDR1 | (ECC_END_ADDR1 << 16);
|
||||||
writel(ecc_ctrl, EMIF1_BASE + KS2_DDR3_ECC_ADDR_RANGE1_OFFSET);
|
writel(ecc_ctrl, EMIF1_BASE + KS2_DDR3_ECC_ADDR_RANGE1_OFFSET);
|
||||||
@@ -214,6 +210,11 @@ static int ddr_memory_ecc_err(u32 addr, u32 ecc_err)
|
|||||||
writel(ecc_ctrl, &emif->emif_ecc_ctrl_reg);
|
writel(ecc_ctrl, &emif->emif_ecc_ctrl_reg);
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
printf("\tECC test: addr 0x%x, read data 0x%x, written data 0x%x, err pattern: 0x%x, read after write data 0x%x\n",
|
||||||
|
addr, val1, val2, ecc_err, val3);
|
||||||
|
|
||||||
|
puts("\tECC test: Enabled DDR ECC ...\n");
|
||||||
|
|
||||||
val1 = readl(addr);
|
val1 = readl(addr);
|
||||||
printf("\tECC test: addr 0x%x, read data 0x%x\n", addr, val1);
|
printf("\tECC test: addr 0x%x, read data 0x%x\n", addr, val1);
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user