dany/u-boot-megous
1
0
Fork 0
mirror of https://xff.cz/git/u-boot/ synced 2025-09-25 20:41:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

dm: ofnode: use fdt32_t for DT property value to fix sparse warning

Browse Source 
DTB is encoded in big endian.  When we retrieve property values,
we need to use fdt32_to_cpu (aka be32_to_cpu) for endian conversion.
This is a bit error-prone, but sparse is useful to detect endian
mismatch.

We need to use (fdt32_t *) instead of (u32 *) for a pointer of a
property value.  Otherwise sparse warns "cast to restricted __be32".

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Masahiro Yamada
2017-06-22 17:57:50 +09:00
committed by Simon Glass
parent fce136aafe
commit 8c9eaadaaa
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/core/ofnode.c
View File

@@ -23,7 +23,7 @@ int ofnode_read_u32(ofnode node, const char *propname, u32 *outp)
if (ofnode_is_np(node)) { if (ofnode_is_np(node)) {
return of_read_u32(ofnode_to_np(node), propname, outp); return of_read_u32(ofnode_to_np(node), propname, outp);
} else { } else {
const int *cell; const fdt32_t *cell;
int len; int len;
cell = fdt_getprop(gd->fdt_blob, ofnode_to_offset(node), cell = fdt_getprop(gd->fdt_blob, ofnode_to_offset(node),
@@ -487,7 +487,7 @@ const uint8_t *ofnode_read_u8_array_ptr(ofnode node, const char *propname,
int ofnode_read_pci_addr(ofnode node, enum fdt_pci_space type, int ofnode_read_pci_addr(ofnode node, enum fdt_pci_space type,
const char *propname, struct fdt_pci_addr *addr) const char *propname, struct fdt_pci_addr *addr)
{ {
const u32 *cell; const fdt32_t *cell;
int len; int len;
int ret = -ENOENT; int ret = -ENOENT;