mirror of
https://xff.cz/git/u-boot/
synced 2025-09-01 00:32:04 +02:00
serial: remove calls to serial_assign()
Remove calls to serial_assign() that are failing now that it returns a proper error code. This calls were not actually doing anything because they passed the name of a stdio_dev when a serial_device name is exptectd. Signed-off-by: Allen Martin <amartin@nvidia.com> Acked-by: Joe Hershberger <joe.hershberger@ni.com> Acked-by: Marek Vasut <marex@denx.de> Acked-by: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> Tested-by: Stephen Warren <swarren@nvidia.com>
This commit is contained in:
@@ -135,16 +135,6 @@ int iomux_doenv(const int console, const char *arg)
|
||||
*/
|
||||
if (console_assign(console, start[j]) < 0)
|
||||
continue;
|
||||
/*
|
||||
* This was taken from common/cmd_nvedit.c.
|
||||
* This will never work because serial_assign() returns
|
||||
* 1 upon error, not -1.
|
||||
* This would almost always return an error anyway because
|
||||
* serial_assign() expects the name of a serial device, like
|
||||
* serial_smc, but the user generally only wants to set serial.
|
||||
*/
|
||||
if (serial_assign(start[j]) < 0)
|
||||
continue;
|
||||
cons_set[cs_idx++] = dev;
|
||||
}
|
||||
free(console_args);
|
||||
|
Reference in New Issue
Block a user