mirror of
https://xff.cz/git/u-boot/
synced 2025-09-01 16:52:14 +02:00
patman: Support collecting response tags in Patchstream
Collect response tags such as 'Reviewed-by' while parsing the stream. This allows us to see what tags are present. Add a new 'Fixes' tag also, since this is now quite common. Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
@@ -37,7 +37,7 @@ re_change_id = re.compile('^Change-Id: *(.*)')
|
||||
re_commit_tag = re.compile('^Commit-([a-z-]*): *(.*)')
|
||||
|
||||
# Commit tags that we want to collect and keep
|
||||
re_tag = re.compile('^(Tested-by|Acked-by|Reviewed-by|Patch-cc): (.*)')
|
||||
re_tag = re.compile('^(Tested-by|Acked-by|Reviewed-by|Patch-cc|Fixes): (.*)')
|
||||
|
||||
# The start of a new commit in the git log
|
||||
re_commit = re.compile('^commit ([0-9a-f]*)$')
|
||||
@@ -112,6 +112,15 @@ class PatchStream:
|
||||
self.in_section = 'commit-' + name
|
||||
self.skip_blank = False
|
||||
|
||||
def AddCommitRtag(self, rtag_type, who):
|
||||
"""Add a response tag to the current commit
|
||||
|
||||
Args:
|
||||
key: rtag type (e.g. 'Reviewed-by')
|
||||
who: Person who gave that rtag, e.g. 'Fred Bloggs <fred@bloggs.org>'
|
||||
"""
|
||||
self.commit.AddRtag(rtag_type, who)
|
||||
|
||||
def CloseCommit(self):
|
||||
"""Save the current commit into our commit list, and reset our state"""
|
||||
if self.commit and self.is_log:
|
||||
@@ -346,12 +355,14 @@ class PatchStream:
|
||||
|
||||
# Detect tags in the commit message
|
||||
elif tag_match:
|
||||
rtag_type, who = tag_match.groups()
|
||||
self.AddCommitRtag(rtag_type, who)
|
||||
# Remove Tested-by self, since few will take much notice
|
||||
if (tag_match.group(1) == 'Tested-by' and
|
||||
tag_match.group(2).find(os.getenv('USER') + '@') != -1):
|
||||
if (rtag_type == 'Tested-by' and
|
||||
who.find(os.getenv('USER') + '@') != -1):
|
||||
self.warn.append("Ignoring %s" % line)
|
||||
elif tag_match.group(1) == 'Patch-cc':
|
||||
self.commit.AddCc(tag_match.group(2).split(','))
|
||||
elif rtag_type == 'Patch-cc':
|
||||
self.commit.AddCc(who.split(','))
|
||||
else:
|
||||
out = [line]
|
||||
|
||||
|
Reference in New Issue
Block a user