mirror of
https://xff.cz/git/u-boot/
synced 2025-09-03 09:42:22 +02:00
hush: return consistent codes from run_command()
Attempting to run: - an empty string - a string with just spaces returns different error codes, 1 for the empty string and 0 for the string with just spaces. Make both of them return 0 for consistency. Signed-off-by: Rabin Vincent <rabin@rab.in> Acked-by: Simon Glass <sjg@chromium.org)
This commit is contained in:
@@ -3236,8 +3236,10 @@ int parse_string_outer(const char *s, int flag)
|
|||||||
#ifdef __U_BOOT__
|
#ifdef __U_BOOT__
|
||||||
char *p = NULL;
|
char *p = NULL;
|
||||||
int rcode;
|
int rcode;
|
||||||
if ( !s || !*s)
|
if (!s)
|
||||||
return 1;
|
return 1;
|
||||||
|
if (!*s)
|
||||||
|
return 0;
|
||||||
if (!(p = strchr(s, '\n')) || *++p) {
|
if (!(p = strchr(s, '\n')) || *++p) {
|
||||||
p = xmalloc(strlen(s) + 2);
|
p = xmalloc(strlen(s) + 2);
|
||||||
strcpy(p, s);
|
strcpy(p, s);
|
||||||
|
@@ -188,6 +188,9 @@ static int do_ut_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
|
|||||||
#endif
|
#endif
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
assert(run_command("", 0) == 0);
|
||||||
|
assert(run_command(" ", 0) == 0);
|
||||||
|
|
||||||
printf("%s: Everything went swimmingly\n", __func__);
|
printf("%s: Everything went swimmingly\n", __func__);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user