mirror of
https://xff.cz/git/u-boot/
synced 2025-09-01 00:32:04 +02:00
Fix hash verification
Fix issue in parse_verify_sum() which swaps handling of env-var and *address. Move hash_command() argc check earlier. Cosmetic change on do_hash() variable declaration. Improved help message for "hash" command. Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg> Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
committed by
Tom Rini
parent
d210718d9a
commit
3ef46a998a
@@ -256,7 +256,7 @@ static int parse_verify_sum(struct hash_algo *algo, char *verify_str,
|
||||
env_var = 1;
|
||||
}
|
||||
|
||||
if (env_var) {
|
||||
if (!env_var) {
|
||||
ulong addr;
|
||||
void *buf;
|
||||
|
||||
@@ -347,7 +347,7 @@ int hash_command(const char *algo_name, int flags, cmd_tbl_t *cmdtp, int flag,
|
||||
{
|
||||
ulong addr, len;
|
||||
|
||||
if (argc < 2)
|
||||
if ((argc < 2) || ((flags & HASH_FLAG_VERIFY) && (argc < 3)))
|
||||
return CMD_RET_USAGE;
|
||||
|
||||
addr = simple_strtoul(*argv++, NULL, 16);
|
||||
@@ -380,8 +380,6 @@ int hash_command(const char *algo_name, int flags, cmd_tbl_t *cmdtp, int flag,
|
||||
#else
|
||||
if (0) {
|
||||
#endif
|
||||
if (!argc)
|
||||
return CMD_RET_USAGE;
|
||||
if (parse_verify_sum(algo, *argv, vsum,
|
||||
flags & HASH_FLAG_ENV)) {
|
||||
printf("ERROR: %s does not contain a valid "
|
||||
|
Reference in New Issue
Block a user