mirror of
				https://xff.cz/git/u-boot/
				synced 2025-10-31 02:15:45 +01:00 
			
		
		
		
	efi_loader: EFI_VARIABLE_READ_ONLY should be 32bit
GetVariable() and SetVariable() only accept a 32bit value for attributes. It makes not sense to define EFI_VARIABLE_READ_ONLY as unsigned long. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
This commit is contained in:
		| @@ -8,7 +8,7 @@ | ||||
|  | ||||
| #include <linux/bitops.h> | ||||
|  | ||||
| #define EFI_VARIABLE_READ_ONLY BIT(31) | ||||
| #define EFI_VARIABLE_READ_ONLY 0x80000000 | ||||
|  | ||||
| enum efi_auth_var_type { | ||||
| 	EFI_AUTH_VAR_NONE = 0, | ||||
|   | ||||
| @@ -276,8 +276,8 @@ efi_status_t efi_set_variable_int(const u16 *variable_name, | ||||
| 		/* attributes won't be changed */ | ||||
| 		if (!delete && | ||||
| 		    ((ro_check && var->attr != attributes) || | ||||
| 		     (!ro_check && ((var->attr & ~(u32)EFI_VARIABLE_READ_ONLY) | ||||
| 				    != (attributes & ~(u32)EFI_VARIABLE_READ_ONLY))))) { | ||||
| 		     (!ro_check && ((var->attr & ~EFI_VARIABLE_READ_ONLY) | ||||
| 				    != (attributes & ~EFI_VARIABLE_READ_ONLY))))) { | ||||
| 			return EFI_INVALID_PARAMETER; | ||||
| 		} | ||||
| 		time = var->time; | ||||
|   | ||||
		Reference in New Issue
	
	Block a user