dany/u-boot-megous
1
0
Fork 0
mirror of https://xff.cz/git/u-boot/ synced 2025-09-02 01:02:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

hush: make run_command() return an error on parsing failure

Browse Source 
run_command() returns success even if the command had a syntax error;
correct this behaviour.

Signed-off-by: Rabin Vincent <rabin@rab.in>
Acked-by: Simon Glass <sjg@chromium.org)
This commit is contained in:
Rabin Vincent
2014-10-29 23:21:41 +01:00
committed by Tom Rini
parent 128059b926
commit 2302b3ab85
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
common/cli_hush.c
View File

@@ -3162,7 +3162,7 @@ static int parse_stream_outer(struct in_str *inp, int flag)
o_string temp=NULL_O_STRING; o_string temp=NULL_O_STRING;
int rcode; int rcode;
#ifdef __U_BOOT__ #ifdef __U_BOOT__
int code = 0; int code = 1;
#endif #endif
do { do {
ctx.type = flag; ctx.type = flag;

2
test/command_ut.c
View File

@@ -191,6 +191,8 @@ static int do_ut_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
assert(run_command("", 0) == 0); assert(run_command("", 0) == 0);
assert(run_command(" ", 0) == 0); assert(run_command(" ", 0) == 0);
assert(run_command("'", 0) == 1);
printf("%s: Everything went swimmingly\n", __func__); printf("%s: Everything went swimmingly\n", __func__);
return 0; return 0;
} }