From cc5d4df973b79ec34f3fde37e45f24f0738d90f3 Mon Sep 17 00:00:00 2001 From: Javier Martinez Canillas Date: Wed, 7 Feb 2024 14:43:30 +0100 Subject: [PATCH] rmtfs: Fix a couple of possible uninitialized variables usage MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GCC version 13.2.1 20231205 complains about the following: cc -Wall -g -O2 -c -o storage.o storage.c In function ‘rmtfs_iovec’, inlined from ‘handle_rmtfs’ at rmtfs.c:403:4: rmtfs.c:224:12: warning: ‘is_write’ may be used uninitialized [-Wmaybe-uninitialized] 224 | if (is_write) | ^ rmtfs.c: In function ‘handle_rmtfs’: rmtfs.c:158:17: note: ‘is_write’ was declared here 158 | uint8_t is_write; | ^ In function ‘rmtfs_iovec’, inlined from ‘handle_rmtfs’ at rmtfs.c:403:4: rmtfs.c:225:17: warning: ‘rmtfd’ may be used uninitialized [-Wmaybe-uninitialized] 225 | storage_sync(rmtfd); | ^~~~~~~~~~~~~~~~~~~ rmtfs.c: In function ‘handle_rmtfs’: rmtfs.c:154:23: note: ‘rmtfd’ was declared here 154 | struct rmtfd *rmtfd; | ^~~~~ Signed-off-by: Javier Martinez Canillas --- rmtfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rmtfs.c b/rmtfs.c index ffca070..0d697b5 100644 --- a/rmtfs.c +++ b/rmtfs.c @@ -151,11 +151,11 @@ static void rmtfs_iovec(int sock, struct qrtr_packet *pkt) struct rmtfs_iovec_resp resp = {}; struct rmtfs_iovec_req req = {}; DEFINE_QRTR_PACKET(resp_buf, 256); - struct rmtfd *rmtfd; + struct rmtfd *rmtfd = NULL; uint32_t caller_id = 0; size_t num_entries = 0; off_t sector_base; - uint8_t is_write; + uint8_t is_write = 0; off_t phys_base; uint8_t force = 0; unsigned txn;