mirror of
https://github.com/webmproject/libwebp.git
synced 2025-10-31 02:15:42 +01:00
e298e05f66
It substitutes patch-check and style-check by: - man format checks and warnings - long lines (max 80, except urls) - trailing whitespaces - tab indentation (except make) - EOL Change-Id: I33f391bac37c15e995182d735afdbd4efb5c7cae Bug: b:185520507
112 lines
4.4 KiB
Python
112 lines
4.4 KiB
Python
# Copyright (c) 2021, Google Inc. All rights reserved.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions are
|
|
# met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
#
|
|
# * Redistributions in binary form must reproduce the above copyright
|
|
# notice, this list of conditions and the following disclaimer in
|
|
# the documentation and/or other materials provided with the
|
|
# distribution.
|
|
#
|
|
# * Neither the name of Google nor the names of its contributors may
|
|
# be used to endorse or promote products derived from this software
|
|
# without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
"""Top-level presubmit script for libwebp.
|
|
|
|
See https://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
|
|
details on the presubmit API built into depot_tools.
|
|
"""
|
|
|
|
import subprocess2
|
|
USE_PYTHON3 = True
|
|
_INCLUDE_MAN_FILES_ONLY = [r"man/.+\.1$"]
|
|
_LIBWEBP_MAX_LINE_LENGTH = 80
|
|
|
|
|
|
def _RunManCmd(input_api, output_api, man_file):
|
|
"""man command wrapper."""
|
|
cmd = ["man", "--warnings", "-EUTF-8", "-l", "-Tutf8", "-Z", man_file]
|
|
name = "Check %s file." % man_file
|
|
start = input_api.time.time()
|
|
output, _ = subprocess2.communicate(cmd,
|
|
stdout=None,
|
|
stderr=subprocess2.PIPE,
|
|
universal_newlines=True)
|
|
duration = input_api.time.time() - start
|
|
if output[1]:
|
|
return output_api.PresubmitError(
|
|
"%s\n%s (%4.2fs) failed\n%s" %
|
|
(name, " ".join(cmd), duration, output[1]))
|
|
return output_api.PresubmitResult("%s\n%s (%4.2fs)\n" %
|
|
(name, " ".join(cmd), duration))
|
|
|
|
|
|
def _CheckManFiles(input_api, output_api):
|
|
"""Makes sure that libwebp/ man files are clean."""
|
|
|
|
man_sources = lambda x: input_api.FilterSourceFile(
|
|
x, files_to_check=_INCLUDE_MAN_FILES_ONLY, files_to_skip=None)
|
|
|
|
affected_man_files = input_api.change.AffectedFiles(
|
|
file_filter=man_sources)
|
|
results = [
|
|
_RunManCmd(input_api, output_api, man_file.AbsoluteLocalPath())
|
|
for man_file in affected_man_files
|
|
]
|
|
return results
|
|
|
|
|
|
def _CommonChecks(input_api, output_api):
|
|
"""Ensures this patch does not have trailing spaces, extra EOLs,
|
|
or long lines.
|
|
"""
|
|
|
|
results = []
|
|
results.extend(
|
|
input_api.canned_checks.CheckChangeHasNoCrAndHasOnlyOneEol(
|
|
input_api, output_api))
|
|
results.extend(
|
|
input_api.canned_checks.CheckChangeHasNoTabs(input_api, output_api))
|
|
results.extend(
|
|
input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
|
|
input_api, output_api))
|
|
results.extend(
|
|
input_api.canned_checks.CheckLongLines(
|
|
input_api, output_api, maxlen=_LIBWEBP_MAX_LINE_LENGTH))
|
|
results.extend(
|
|
input_api.canned_checks.CheckPatchFormatted(input_api,
|
|
output_api,
|
|
check_clang_format=False,
|
|
check_python=True))
|
|
return results
|
|
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
results = []
|
|
results.extend(_CommonChecks(input_api, output_api))
|
|
results.extend(_CheckManFiles(input_api, output_api))
|
|
return results
|
|
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
results = []
|
|
results.extend(_CommonChecks(input_api, output_api))
|
|
results.extend(_CheckManFiles(input_api, output_api))
|
|
return results
|