From e69a1df4b75b511906af6919856207fa94a639cc Mon Sep 17 00:00:00 2001 From: James Zern Date: Tue, 29 Apr 2014 19:54:56 +0000 Subject: [PATCH] dec/vp8l: prevent signed int overflow in left shift ops force unsigned when shifting by 24. Change-Id: I6f9ca5fa2109e59b1d46a909136384fc6dc8ca0b --- src/dec/vp8l.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dec/vp8l.c b/src/dec/vp8l.c index 8712771c..307d7ac1 100644 --- a/src/dec/vp8l.c +++ b/src/dec/vp8l.c @@ -851,7 +851,7 @@ static int DecodeImageData(VP8LDecoder* const dec, uint32_t* const data, VP8LFillBitWindow(br); blue = ReadSymbol(&htree_group->htrees_[BLUE], br); alpha = ReadSymbol(&htree_group->htrees_[ALPHA], br); - *src = (alpha << 24) | (red << 16) | (green << 8) | blue; + *src = ((uint32_t)alpha << 24) | (red << 16) | (green << 8) | blue; AdvanceByOne: ++src; ++col;