dany/libwebp
1
0
Fork 0
mirror of https://github.com/webmproject/libwebp.git synced 2024-12-27 06:08:21 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

add WEBP_MSAN

Browse Source 
and use it to suppress a false positive related to data that passes
through RGBA32PackedToPlanar_16b_SSE41(). Current versions (tested with
clang 13.0.1, using -O0 and the build from oss-fuzz of enc_dec_fuzzer)
model shuffles incorrectly reporting use of uninitialized
data related to the alpha change that's removed when converting to YUV.
valgrind behaves correctly, however.

Bug: webp:573
Change-Id: If76997668dcdd436adf280a2e6dcffba766a2875
This commit is contained in:
James Zern 2022-06-14 21:45:26 -07:00
parent 5ecee06f7a
commit e15b356014
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/dsp/cpu.h
View File

@ -147,6 +147,12 @@
#endif #endif
#endif #endif
#if defined(__has_feature)
#if __has_feature(memory_sanitizer)
#define WEBP_MSAN
#endif
#endif
#if defined(WEBP_USE_THREAD) && !defined(_WIN32) #if defined(WEBP_USE_THREAD) && !defined(_WIN32)
#include <pthread.h> // NOLINT #include <pthread.h> // NOLINT

9
src/enc/picture_csp_enc.c
View File

@ -451,11 +451,20 @@ static WEBP_INLINE void AccumulateRGB(const uint8_t* const r_ptr,
dst[0] = SUM4(r_ptr + j, step); dst[0] = SUM4(r_ptr + j, step);
dst[1] = SUM4(g_ptr + j, step); dst[1] = SUM4(g_ptr + j, step);
dst[2] = SUM4(b_ptr + j, step); dst[2] = SUM4(b_ptr + j, step);
// MemorySanitizer may raise false positives with data that passes through
// RGBA32PackedToPlanar_16b_SSE41() due to incorrect modeling of shuffles.
// See https://crbug.com/webp/573.
#ifdef WEBP_MSAN
dst[3] = 0;
#endif
} }
if (width & 1) { if (width & 1) {
dst[0] = SUM2(r_ptr + j); dst[0] = SUM2(r_ptr + j);
dst[1] = SUM2(g_ptr + j); dst[1] = SUM2(g_ptr + j);
dst[2] = SUM2(b_ptr + j); dst[2] = SUM2(b_ptr + j);
#ifdef WEBP_MSAN
dst[3] = 0;
#endif
} }
} }