dany/libwebp
1
0
Fork 0
mirror of https://github.com/webmproject/libwebp.git synced 2025-04-08 09:56:49 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Reformat docstrings and imports

Browse Source 
Change-Id: Ie96a21779000a67c272f5e06d2bc11a64b4883f5
Bug: b:185520494
This commit is contained in:
Roberto Alanis 2021-10-01 14:47:02 +00:00
parent edaf08952d
commit abcd1797a1
2 changed files with 55 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.style.yapf Normal file
View File

@ -0,0 +1,2 @@
[style]
based_on_style = chromium

109
PRESUBMIT.py
View File

@ -34,80 +34,77 @@ details on the presubmit API built into depot_tools.
""" """
import subprocess2 import subprocess2
USE_PYTHON3 = True USE_PYTHON3 = True
_INCLUDE_MAN_FILES_ONLY = [r"man/.+\.1$"] _INCLUDE_MAN_FILES_ONLY = [r"man/.+\.1$"]
_LIBWEBP_MAX_LINE_LENGTH = 80 _LIBWEBP_MAX_LINE_LENGTH = 80
def _RunManCmd(input_api, output_api, man_file): def _RunManCmd(input_api, output_api, man_file):
"""man command wrapper.""" """man command wrapper."""
cmd = ["man", "--warnings", "-EUTF-8", "-l", "-Tutf8", "-Z", man_file] cmd = ["man", "--warnings", "-EUTF-8", "-l", "-Tutf8", "-Z", man_file]
name = "Check %s file." % man_file name = "Check %s file." % man_file
start = input_api.time.time() start = input_api.time.time()
output, _ = subprocess2.communicate(cmd, output, _ = subprocess2.communicate(
stdout=None, cmd, stdout=None, stderr=subprocess2.PIPE, universal_newlines=True)
stderr=subprocess2.PIPE, duration = input_api.time.time() - start
universal_newlines=True) if output[1]:
duration = input_api.time.time() - start return output_api.PresubmitError("%s\n%s (%4.2fs) failed\n%s" %
if output[1]: (name, " ".join(cmd), duration, output[1]))
return output_api.PresubmitError( return output_api.PresubmitResult("%s\n%s (%4.2fs)\n" %
"%s\n%s (%4.2fs) failed\n%s" % (name, " ".join(cmd), duration))
(name, " ".join(cmd), duration, output[1]))
return output_api.PresubmitResult("%s\n%s (%4.2fs)\n" %
(name, " ".join(cmd), duration))
def _CheckManFiles(input_api, output_api): def _CheckManFiles(input_api, output_api):
"""Makes sure that libwebp/ man files are clean.""" """Makes sure that libwebp/ man files are clean."""
man_sources = lambda x: input_api.FilterSourceFile( man_sources = lambda x: input_api.FilterSourceFile(
x, files_to_check=_INCLUDE_MAN_FILES_ONLY, files_to_skip=None) x, files_to_check=_INCLUDE_MAN_FILES_ONLY, files_to_skip=None)
affected_man_files = input_api.change.AffectedFiles( affected_man_files = input_api.change.AffectedFiles(file_filter=man_sources)
file_filter=man_sources) results = [
results = [ _RunManCmd(input_api, output_api, man_file.AbsoluteLocalPath())
_RunManCmd(input_api, output_api, man_file.AbsoluteLocalPath()) for man_file in affected_man_files
for man_file in affected_man_files ]
] return results
return results
def _CommonChecks(input_api, output_api): def _CommonChecks(input_api, output_api):
"""Ensures this patch does not have trailing spaces, extra EOLs, """Ensures this patch does not have trailing spaces, extra EOLs,
or long lines. or long lines.
""" """
results = [] results = []
results.extend( results.extend(
input_api.canned_checks.CheckChangeHasNoCrAndHasOnlyOneEol( input_api.canned_checks.CheckChangeHasNoCrAndHasOnlyOneEol(
input_api, output_api)) input_api, output_api))
results.extend( results.extend(
input_api.canned_checks.CheckChangeHasNoTabs(input_api, output_api)) input_api.canned_checks.CheckChangeHasNoTabs(input_api, output_api))
results.extend( results.extend(
input_api.canned_checks.CheckChangeHasNoStrayWhitespace( input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
input_api, output_api)) input_api, output_api))
results.extend( results.extend(
input_api.canned_checks.CheckLongLines( input_api.canned_checks.CheckLongLines(
input_api, output_api, maxlen=_LIBWEBP_MAX_LINE_LENGTH)) input_api, output_api, maxlen=_LIBWEBP_MAX_LINE_LENGTH))
results.extend( results.extend(
input_api.canned_checks.CheckPatchFormatted( input_api.canned_checks.CheckPatchFormatted(
input_api, input_api,
output_api, output_api,
check_clang_format=False, check_clang_format=False,
check_python=True, check_python=True,
result_factory=output_api.PresubmitError)) result_factory=output_api.PresubmitError))
return results return results
def CheckChangeOnUpload(input_api, output_api): def CheckChangeOnUpload(input_api, output_api):
results = [] results = []
results.extend(_CommonChecks(input_api, output_api)) results.extend(_CommonChecks(input_api, output_api))
results.extend(_CheckManFiles(input_api, output_api)) results.extend(_CheckManFiles(input_api, output_api))
return results return results
def CheckChangeOnCommit(input_api, output_api): def CheckChangeOnCommit(input_api, output_api):
results = [] results = []
results.extend(_CommonChecks(input_api, output_api)) results.extend(_CommonChecks(input_api, output_api))
results.extend(_CheckManFiles(input_api, output_api)) results.extend(_CheckManFiles(input_api, output_api))
return results return results