dany/libwebp
1
0
Fork 0
mirror of https://github.com/webmproject/libwebp.git synced 2024-12-25 13:18:22 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

patch-check: detect duplicated files

Browse Source 
Change-Id: Ia78425e7f8054d4b0b4e6b365ba0f5887cbcf2d1
Bug: b:185520507
This commit is contained in:
Roberto Alanis 2021-12-15 07:18:13 +00:00
parent 5b7e79303a
commit a510fedb9a
1 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
PRESUBMIT.py
View File

@ -41,6 +41,7 @@ _BASH_INDENTATION = "2"
_GIT_COMMIT_SUBJECT_LENGTH = 65 _GIT_COMMIT_SUBJECT_LENGTH = 65
_INCLUDE_BASH_FILES_ONLY = [r".*\.sh$"] _INCLUDE_BASH_FILES_ONLY = [r".*\.sh$"]
_INCLUDE_MAN_FILES_ONLY = [r"man/.+\.1$"] _INCLUDE_MAN_FILES_ONLY = [r"man/.+\.1$"]
_INCLUDE_SOURCE_FILES_ONLY = [r".*\.[ch]$"]
_LIBWEBP_MAX_LINE_LENGTH = 80 _LIBWEBP_MAX_LINE_LENGTH = 80
@ -72,6 +73,35 @@ def _CheckCommitSubjectLength(input_api, output_api):
return output_api.PresubmitResult("%s\n (%4.2fs) success" % (name, duration)) return output_api.PresubmitResult("%s\n (%4.2fs) success" % (name, duration))
def _CheckDuplicateFiles(input_api, output_api):
"""Ensures there are not repeated filenames."""
all_files = []
for f in input_api.change.AllFiles():
for include_file in _INCLUDE_SOURCE_FILES_ONLY:
if re.match(include_file, f):
all_files.append(f)
break
basename_to_path = {}
for f in all_files:
basename_file = input_api.basename(f)
if basename_file in basename_to_path:
basename_to_path[basename_file].append(f)
else:
basename_to_path[basename_file] = [f]
dupes = []
for files in basename_to_path.values():
if len(files) > 1:
dupes.extend(files)
if dupes:
return output_api.PresubmitError(
"Duplicate source files, rebase or rename some to make them unique:\n%s"
% dupes)
return output_api.PresubmitResult("No duplicates, success\n")
def _GetFilesToSkip(input_api): def _GetFilesToSkip(input_api):
return list(input_api.DEFAULT_FILES_TO_SKIP) + [ return list(input_api.DEFAULT_FILES_TO_SKIP) + [
r"swig/.*\.py$", r"swig/.*\.py$",
@ -154,6 +184,7 @@ def _CommonChecks(input_api, output_api):
input_api.canned_checks.CheckChangeHasNoStrayWhitespace( input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
input_api, output_api)) input_api, output_api))
results.append(_CheckCommitSubjectLength(input_api, output_api)) results.append(_CheckCommitSubjectLength(input_api, output_api))
results.append(_CheckDuplicateFiles(input_api, output_api))
source_file_filter = lambda x: input_api.FilterSourceFile( source_file_filter = lambda x: input_api.FilterSourceFile(
x, files_to_skip=_GetFilesToSkip(input_api)) x, files_to_skip=_GetFilesToSkip(input_api))