dany/libwebp
1
0
Fork 0
mirror of https://github.com/webmproject/libwebp.git synced 2025-04-03 23:46:49 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

cosmetics: remove use of the term 'dummy'

Browse Source 
this is replaced with more inclusive / informative text

Bug: webp:507
Change-Id: Ib77f0c79dd548601bf2bc3169985af4b5edf0a62
This commit is contained in:
James Zern 2021-03-15 11:32:26 -07:00
parent 01b38ee19a
commit 5d4ee4c3c0
5 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
examples/webpmux.c
View File

@ -472,11 +472,11 @@ static WebPMux* DuplicateMuxHeader(const WebPMux* const mux) {
} }
static int ParseFrameArgs(const char* args, WebPMuxFrameInfo* const info) { static int ParseFrameArgs(const char* args, WebPMuxFrameInfo* const info) {
int dispose_method, dummy; int dispose_method, unused;
char plus_minus, blend_method; char plus_minus, blend_method;
const int num_args = sscanf(args, "+%d+%d+%d+%d%c%c+%d", &info->duration, const int num_args = sscanf(args, "+%d+%d+%d+%d%c%c+%d", &info->duration,
&info->x_offset, &info->y_offset, &dispose_method, &info->x_offset, &info->y_offset, &dispose_method,
&plus_minus, &blend_method, &dummy); &plus_minus, &blend_method, &unused);
switch (num_args) { switch (num_args) {
case 1: case 1:
info->x_offset = info->y_offset = 0; // fall through info->x_offset = info->y_offset = 0; // fall through

6
imageio/image_enc.c
View File

@ -155,8 +155,8 @@ int WebPWritePNG(const char* out_file_name, int use_stdout,
} }
#elif defined(WEBP_HAVE_PNG) // !HAVE_WINCODEC_H #elif defined(WEBP_HAVE_PNG) // !HAVE_WINCODEC_H
static void PNGAPI PNGErrorFunction(png_structp png, png_const_charp dummy) { static void PNGAPI PNGErrorFunction(png_structp png, png_const_charp unused) {
(void)dummy; // remove variable-unused warning (void)unused; // remove variable-unused warning
longjmp(png_jmpbuf(png), 1); longjmp(png_jmpbuf(png), 1);
} }
@ -320,7 +320,7 @@ int WebPWriteBMP(FILE* fout, const WebPDecBuffer* const buffer) {
PutLE16(bmp_header + 26, 1); // number of planes PutLE16(bmp_header + 26, 1); // number of planes
PutLE16(bmp_header + 28, bytes_per_px * 8); // bits per pixel PutLE16(bmp_header + 28, bytes_per_px * 8); // bits per pixel
PutLE32(bmp_header + 30, 0); // no compression (BI_RGB) PutLE32(bmp_header + 30, 0); // no compression (BI_RGB)
PutLE32(bmp_header + 34, 0); // image size (dummy) PutLE32(bmp_header + 34, 0); // image size (placeholder)
PutLE32(bmp_header + 38, 2400); // x pixels/meter PutLE32(bmp_header + 38, 2400); // x pixels/meter
PutLE32(bmp_header + 42, 2400); // y pixels/meter PutLE32(bmp_header + 42, 2400); // y pixels/meter
PutLE32(bmp_header + 46, 0); // number of palette colors PutLE32(bmp_header + 46, 0); // number of palette colors

5
src/dsp/cpu.c
View File

@ -210,8 +210,9 @@ static int wasmCPUInfo(CPUFeature feature) {
} }
VP8CPUInfo VP8GetCPUInfo = wasmCPUInfo; VP8CPUInfo VP8GetCPUInfo = wasmCPUInfo;
#elif defined(WEBP_USE_NEON) #elif defined(WEBP_USE_NEON)
// define a dummy function to enable turning off NEON at runtime by setting // In most cases this function doesn't check for NEON support (it's assumed by
// VP8DecGetCPUInfo = NULL // the configuration), but enables turning off NEON at runtime, for testing
// purposes, by setting VP8DecGetCPUInfo = NULL.
static int armCPUInfo(CPUFeature feature) { static int armCPUInfo(CPUFeature feature) {
if (feature != kNEON) return 0; if (feature != kNEON) return 0;
#if defined(__linux__) && defined(WEBP_HAVE_NEON_RTCD) #if defined(__linux__) && defined(WEBP_HAVE_NEON_RTCD)

4
src/enc/alpha_enc.c
View File

@ -361,7 +361,7 @@ static int EncodeAlpha(VP8Encoder* const enc,
//------------------------------------------------------------------------------ //------------------------------------------------------------------------------
// Main calls // Main calls
static int CompressAlphaJob(void* arg1, void* dummy) { static int CompressAlphaJob(void* arg1, void* unused) {
VP8Encoder* const enc = (VP8Encoder*)arg1; VP8Encoder* const enc = (VP8Encoder*)arg1;
const WebPConfig* config = enc->config_; const WebPConfig* config = enc->config_;
uint8_t* alpha_data = NULL; uint8_t* alpha_data = NULL;
@ -381,7 +381,7 @@ static int CompressAlphaJob(void* arg1, void* dummy) {
} }
enc->alpha_data_size_ = (uint32_t)alpha_size; enc->alpha_data_size_ = (uint32_t)alpha_size;
enc->alpha_data_ = alpha_data; enc->alpha_data_ = alpha_data;
(void)dummy; (void)unused;
return 1; return 1;
} }

2
swig/libwebp_python_wrap.c
View File

@ -2764,7 +2764,7 @@ SWIG_Python_DestroyModule(void *vptr)
SWIGRUNTIME void SWIGRUNTIME void
SWIG_Python_SetModule(swig_module_info *swig_module) { SWIG_Python_SetModule(swig_module_info *swig_module) {
#if PY_VERSION_HEX >= 0x03000000 #if PY_VERSION_HEX >= 0x03000000
/* Add a dummy module object into sys.modules */ /* Add a placeholder module object into sys.modules */
PyObject *module = PyImport_AddModule((char*)"swig_runtime_data" SWIG_RUNTIME_VERSION); PyObject *module = PyImport_AddModule((char*)"swig_runtime_data" SWIG_RUNTIME_VERSION);
#else #else
static PyMethodDef swig_empty_runtime_method_table[] = { {NULL, NULL, 0, NULL} }; /* Sentinel */ static PyMethodDef swig_empty_runtime_method_table[] = { {NULL, NULL, 0, NULL} }; /* Sentinel */