dany/libwebp
1
0
Fork 0
mirror of https://github.com/webmproject/libwebp.git synced 2025-02-13 15:32:53 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "gifdec,Remap: avoid out of bounds colormap read"

Browse Source 
This reverts commit f048d38d380ef042bb1b5f3a2e5ecc729a5c826a.

the 'len' in Remap refers to the src[] not the colormap; this change
breaks valid files

BUG=webp:316

Change-Id: I1ed40075c2194df91d345cb6f29619b1f5cc96fc
This commit is contained in:
James Zern 2016-11-01 21:02:54 -07:00
parent fb52d4432a
commit 4595e01fd0
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
examples/gifdec.c
View File

@ -87,8 +87,7 @@ static void Remap(const GifFileType* const gif, const uint8_t* const src,
const GifColorType* colors; const GifColorType* colors;
const ColorMapObject* const cmap = const ColorMapObject* const cmap =
gif->Image.ColorMap ? gif->Image.ColorMap : gif->SColorMap; gif->Image.ColorMap ? gif->Image.ColorMap : gif->SColorMap;
if (cmap == NULL || cmap->Colors == NULL) return; if (cmap == NULL) return;
if (len > cmap->ColorCount) len = cmap->ColorCount;
colors = cmap->Colors; colors = cmap->Colors;
for (i = 0; i < len; ++i) { for (i = 0; i < len; ++i) {