From fd3d1fc34461328412d37fee63df4ebea76b2629 Mon Sep 17 00:00:00 2001 From: Patrik Jakobsson Date: Sun, 22 May 2016 01:42:51 +0200 Subject: [PATCH] fthd/debug: Coding style cleanups Signed-off-by: Patrik Jakobsson --- fthd_debugfs.c | 39 +++++++++++++++++++++++++++------------ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/fthd_debugfs.c b/fthd_debugfs.c index 01164e8..aea4fe6 100644 --- a/fthd_debugfs.c +++ b/fthd_debugfs.c @@ -70,7 +70,8 @@ static ssize_t fthd_store_debug(struct file *file, const char __user *user_buf, opcode = CISP_CMD_DEBUG_GET_DEBUG_LEVEL; else if (sscanf(buf, "set_debug_level %x %i", &cmd.arg[0], &cmd.arg[1]) == 2) opcode = CISP_CMD_DEBUG_SET_DEBUG_LEVEL; - else if (sscanf(buf, "set_debug_level_rec %x %i", &cmd.arg[0], &cmd.arg[1]) == 2) + else if (sscanf(buf, "set_debug_level_rec %x %i", &cmd.arg[0], + &cmd.arg[1]) == 2) opcode = CISP_CMD_DEBUG_SET_DEBUG_LEVEL_RECURSIVE; else if (!strcmp(buf, "get_fsm_count")) opcode = CISP_CMD_DEBUG_GET_FSM_COUNT; @@ -94,9 +95,8 @@ static ssize_t fthd_store_debug(struct file *file, const char __user *user_buf, return count; } - static int seq_channel_read(struct seq_file *seq, struct fthd_private *dev_priv, - struct fw_channel *chan) + struct fw_channel *chan) { int i; char pos; @@ -109,7 +109,8 @@ static int seq_channel_read(struct seq_file *seq, struct fthd_private *dev_priv, else pos = ' '; entry = get_entry_addr(dev_priv, chan, i); - seq_printf(seq, "%c%3.3d: ADDRESS %08x REQUEST_SIZE %08x RESPONSE_SIZE %08x\n", + seq_printf(seq, + "%c%3.3d: ADDRESS %08x REQUEST_SIZE %08x RESPONSE_SIZE %08x\n", pos, i, FTHD_S2_MEM_READ(entry + FTHD_RINGBUF_ADDRESS_FLAGS), FTHD_S2_MEM_READ(entry + FTHD_RINGBUF_REQUEST_SIZE), @@ -190,14 +191,28 @@ int fthd_debugfs_init(struct fthd_private *dev_priv) return PTR_ERR(d); } - debugfs_create_devm_seqfile(&dev_priv->pdev->dev, "channel_terminal", d, seq_channel_terminal_read); - debugfs_create_devm_seqfile(&dev_priv->pdev->dev, "channel_sharedmalloc", d, seq_channel_sharedmalloc_read); - debugfs_create_devm_seqfile(&dev_priv->pdev->dev, "channel_io", d, seq_channel_io_read); - debugfs_create_devm_seqfile(&dev_priv->pdev->dev, "channel_io_t2h", d, seq_channel_io_t2h_read); - debugfs_create_devm_seqfile(&dev_priv->pdev->dev, "channel_buf_h2t", d, seq_channel_buf_h2t_read); - debugfs_create_devm_seqfile(&dev_priv->pdev->dev, "channel_buf_t2h", d, seq_channel_buf_t2h_read); - debugfs_create_devm_seqfile(&dev_priv->pdev->dev, "channel_debug", d, seq_channel_debug_read); - debugfs_create_file("debug", S_IRUSR | S_IWUSR, d, dev_priv, &fops_debug); + debugfs_create_devm_seqfile(&dev_priv->pdev->dev, + "channel_terminal", d, + seq_channel_terminal_read); + debugfs_create_devm_seqfile(&dev_priv->pdev->dev, + "channel_sharedmalloc", + d, seq_channel_sharedmalloc_read); + debugfs_create_devm_seqfile(&dev_priv->pdev->dev, + "channel_io", d, seq_channel_io_read); + debugfs_create_devm_seqfile(&dev_priv->pdev->dev, + "channel_io_t2h", d, + seq_channel_io_t2h_read); + debugfs_create_devm_seqfile(&dev_priv->pdev->dev, + "channel_buf_h2t", d, + seq_channel_buf_h2t_read); + debugfs_create_devm_seqfile(&dev_priv->pdev->dev, + "channel_buf_t2h", d, + seq_channel_buf_t2h_read); + debugfs_create_devm_seqfile(&dev_priv->pdev->dev," + channel_debug", + d, seq_channel_debug_read); + debugfs_create_file("debug", S_IRUSR | S_IWUSR, d, dev_priv, + &fops_debug); dev_priv->debugfs = top; return 0; }