From d665ea9639e13de2cd68d93934b75a84ed88bf04 Mon Sep 17 00:00:00 2001 From: Dylan Van Assche Date: Fri, 9 Apr 2021 10:28:39 +0200 Subject: [PATCH] config: drop URC cache In some internal discussions between me, the ModemManager maintainer and a Quectel engineer, the URC cache we use is unnecessary. I did some testing and removed the URC cache from the configs and it works reliable without affecting the functionality. --- data/pine64,pinephone-1.0.toml | 3 --- data/pine64,pinephone-1.1.toml | 3 --- data/pine64,pinephone-1.2.toml | 3 --- 3 files changed, 9 deletions(-) diff --git a/data/pine64,pinephone-1.0.toml b/data/pine64,pinephone-1.0.toml index cf709f6..e1f5b24 100644 --- a/data/pine64,pinephone-1.0.toml +++ b/data/pine64,pinephone-1.0.toml @@ -45,14 +45,11 @@ configure = [ { cmd = "QURCCFG", subcmd = "urcport", expect = "\"all\"" }, { cmd = "QGPS", value = "1" }, { cmd = "QSCLK", value = "1" }, - { cmd = "QCFG", subcmd = "urc/cache", value = "0" } ] suspend = [ { cmd = "QGPSEND" }, - { cmd = "QCFG", subcmd = "urc/cache", value = "1" } ] resume = [ - { cmd = "QCFG", subcmd = "urc/cache", value = "0" }, { cmd = "QGPS", value = "1" } ] reset = [ { cmd = "CFUN", value = "1,1" } ] diff --git a/data/pine64,pinephone-1.1.toml b/data/pine64,pinephone-1.1.toml index cf709f6..e1f5b24 100644 --- a/data/pine64,pinephone-1.1.toml +++ b/data/pine64,pinephone-1.1.toml @@ -45,14 +45,11 @@ configure = [ { cmd = "QURCCFG", subcmd = "urcport", expect = "\"all\"" }, { cmd = "QGPS", value = "1" }, { cmd = "QSCLK", value = "1" }, - { cmd = "QCFG", subcmd = "urc/cache", value = "0" } ] suspend = [ { cmd = "QGPSEND" }, - { cmd = "QCFG", subcmd = "urc/cache", value = "1" } ] resume = [ - { cmd = "QCFG", subcmd = "urc/cache", value = "0" }, { cmd = "QGPS", value = "1" } ] reset = [ { cmd = "CFUN", value = "1,1" } ] diff --git a/data/pine64,pinephone-1.2.toml b/data/pine64,pinephone-1.2.toml index b22b30f..4ca1274 100644 --- a/data/pine64,pinephone-1.2.toml +++ b/data/pine64,pinephone-1.2.toml @@ -39,14 +39,11 @@ configure = [ { cmd = "QURCCFG", subcmd = "urcport", expect = "\"all\"" }, { cmd = "QGPS", value = "1" }, { cmd = "QSCLK", value = "1" }, - { cmd = "QCFG", subcmd = "urc/cache", value = "0" } ] suspend = [ { cmd = "QGPSEND" }, - { cmd = "QCFG", subcmd = "urc/cache", value = "1" } ] resume = [ - { cmd = "QCFG", subcmd = "urc/cache", value = "0" }, { cmd = "QGPS", value = "1" } ] reset = [ { cmd = "CFUN", value = "1,1" } ]