dany/clapper
1
0
Fork 0
mirror of https://github.com/Rafostar/clapper.git synced 2025-08-30 07:42:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix app close when pressing "Q" during position drag

Browse Source
This commit is contained in:
Rafostar
2021-01-13 19:10:12 +01:00
parent 5d0876bbf7
commit d831113925
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
clapper_src/controls.js vendored
View File

@@ -327,14 +327,14 @@ class ClapperControls extends Gtk.Box
this.positionScale.add_controller(scrollController); this.positionScale.add_controller(scrollController);
this.positionScale.add_css_class('positionscale'); this.positionScale.add_css_class('positionscale');
this.positionScale.connect( this.positionScaleValueSignal = this.positionScale.connect(
'value-changed', this._onPositionScaleValueChanged.bind(this) 'value-changed', this._onPositionScaleValueChanged.bind(this)
); );
/* GTK4 is missing pressed/released signals for GtkRange/GtkScale. /* GTK4 is missing pressed/released signals for GtkRange/GtkScale.
* We cannot add controllers, cause it already has them, so we * We cannot add controllers, cause it already has them, so we
* workaround this by observing css classes it currently has */ * workaround this by observing css classes it currently has */
this.positionScale.connect( this.positionScaleDragSignal = this.positionScale.connect(
'notify::css-classes', this._onPositionScaleDragging.bind(this) 'notify::css-classes', this._onPositionScaleDragging.bind(this)
); );
@@ -628,11 +628,18 @@ class ClapperControls extends Gtk.Box
_onCloseRequest() _onCloseRequest()
{ {
debug('controls close request');
this.positionScale.disconnect(this.positionScaleValueSignal);
this.positionScale.disconnect(this.positionScaleDragSignal);
for(let button of this.buttonsArr) { for(let button of this.buttonsArr) {
if(!button._onCloseRequest) if(!button._onCloseRequest)
continue; continue;
button._onCloseRequest(); button._onCloseRequest();
} }
this.chapterPopover.unparent();
} }
}); });