From a9d455566124785758ca3b9abc47546019af68e5 Mon Sep 17 00:00:00 2001 From: Rafostar <40623528+Rafostar@users.noreply.github.com> Date: Tue, 5 Jan 2021 20:47:57 +0100 Subject: [PATCH] Remove fullscreen-changed signal GTK since 4.0 has fullscreened property that can be used as both a binding and signal with notify. No need to keep the fullscreen-changed signal as part of the app. --- clapper_src/widget.js | 10 ++-------- examples/widget-example.js | 4 +--- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/clapper_src/widget.js b/clapper_src/widget.js index 726d339b..6fbfc8ff 100644 --- a/clapper_src/widget.js +++ b/clapper_src/widget.js @@ -8,13 +8,8 @@ const Revealers = imports.clapper_src.revealers; const { debug } = Debug; const { settings } = Misc; -var Widget = GObject.registerClass({ - Signals: { - 'fullscreen-changed': { - param_types: [GObject.TYPE_BOOLEAN] - } - } -}, class ClapperWidget extends Gtk.Grid +var Widget = GObject.registerClass( +class ClapperWidget extends Gtk.Grid { _init() { @@ -484,7 +479,6 @@ var Widget = GObject.registerClass({ return; this.setFullscreenMode(isFullscreen); - this.emit('fullscreen-changed', isFullscreen); debug(`interface in fullscreen mode: ${isFullscreen}`); } diff --git a/examples/widget-example.js b/examples/widget-example.js index 0555fe4b..22a9c656 100644 --- a/examples/widget-example.js +++ b/examples/widget-example.js @@ -25,9 +25,7 @@ app.connect('activate', () => { }); let widget = new Clapper.Widget(); - widget.connect('fullscreen-changed', (widget, isFullscreen) => { - label.set_visible(!isFullscreen); - }); + window.bind('fullscreened', label, 'visible', GObject.BindingFlags.INVERT_BOOLEAN); window.connect('show', () => { let media = 'http://distribution.bbb3d.renderfarming.net/video/mp4/bbb_sunflower_1080p_30fps_normal.mp4'; widget.player.set_media(media);