dany/clapper
1
0
Fork 0
mirror of https://github.com/Rafostar/clapper.git synced 2025-08-29 23:32:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

clapper-gtk/extra-menu: Fixed speed being forced to the lowest value

Browse Source 
As the SpinButton input callback attempted to parse the value inserted
as a string by printf using g_ascii_strtod, only if the language also
used . (full stop / u002E) as decimal seperator worked correctly.
Otherwise, parsing would fail and result (after a few iterations) in the
lowest value being set.

The usually correct approach is to use g_ascii_dtostr / g_ascii_formatd
instead of printf to format a decimal number, but given that this number
is actually presented to the user, going with g_strtod seems like a
better choice (I've decided against just using the stdlib strtod as to
allow the SpinButton to also recognize manual user input containing the
full stop  instead of their languages native decimal seperator (not
that that'll ever happen, given the user can't focus the SpinButton
entry while media is running).

I've also fixed this for the volume SpinButton too, but it wasn't really
affected in the first place as it appearently always gets rounded up to
a number without decimal places.

Signed-off-by: Florian "sp1rit"​ <sp1rit@disroot.org>
This commit is contained in:
Florian "sp1rit"​
2024-04-10 12:08:23 +02:00
parent 0c9973ef85
commit a63d92601f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/clapper-gtk/clapper-gtk-extra-menu-button.c
View File

@@ -129,7 +129,7 @@ volume_spin_input_cb (GtkSpinButton *spin_button, gdouble *value, ClapperGtkExtr
{ {
const gchar *text = gtk_editable_get_text (GTK_EDITABLE (spin_button)); const gchar *text = gtk_editable_get_text (GTK_EDITABLE (spin_button));
gchar *sign = NULL; gchar *sign = NULL;
gdouble volume = g_ascii_strtod (text, &sign); gdouble volume = g_strtod (text, &sign);
if (volume < 0 || volume > 200 if (volume < 0 || volume > 200
|| (sign && sign[0] != '\0' && sign[0] != '%')) || (sign && sign[0] != '\0' && sign[0] != '%'))
@@ -174,7 +174,7 @@ speed_spin_input_cb (GtkSpinButton *spin_button, gdouble *value, ClapperGtkExtra
{ {
const gchar *text = gtk_editable_get_text (GTK_EDITABLE (spin_button)); const gchar *text = gtk_editable_get_text (GTK_EDITABLE (spin_button));
gchar *sign = NULL; gchar *sign = NULL;
gdouble speed = g_ascii_strtod (text, &sign); gdouble speed = g_strtod (text, &sign);
if (speed < 0.05 || speed > 2.0 if (speed < 0.05 || speed > 2.0
|| (sign && sign[0] != '\0' && sign[0] != 'x')) || (sign && sign[0] != '\0' && sign[0] != 'x'))