dany/clapper
1
0
Fork 0
mirror of https://github.com/Rafostar/clapper.git synced 2025-08-30 16:02:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

clapper-app: Show sink bin child name in info window

Browse Source 
Sinks that are bin types often take another configurable sink through a property.
We want to show what was set there in info window too.
This commit is contained in:
Rafał Dzięgiel
2025-01-18 15:49:42 +01:00
parent e35d04a742
commit 4472d87f8b
2 changed files with 45 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
src/bin/clapper-app/clapper-app-info-window.c
View File

@@ -89,6 +89,48 @@ playback_decoder_closure (ClapperAppInfoWindow *self, GstElement *decoder)
return text;
}
static gchar *
playback_sink_closure (ClapperAppInfoWindow *self, GstElement *sink)
{
GstElementFactory *factory;
GParamSpec *pspec;
gchar *text, *el_name, *child_name = NULL;
if (!sink || !(factory = gst_element_get_factory (sink)))
return NULL;
el_name = gst_object_get_name (GST_OBJECT_CAST (factory));
/* We want to show actual sink if it is configurable
* through a property (e.g. sink of "glsinkbin") */
if (GST_IS_BIN (sink)
&& ((pspec = g_object_class_find_property (G_OBJECT_GET_CLASS (sink), "video-sink"))
|| (pspec = g_object_class_find_property (G_OBJECT_GET_CLASS (sink), "sink")))
&& pspec->value_type == GST_TYPE_ELEMENT) {
GstElement *child = NULL;
GstElementFactory *child_factory;
g_object_get (sink, pspec->name, &child, NULL);
if (child) {
if ((child_factory = gst_element_get_factory (child)))
child_name = gst_object_get_name (GST_OBJECT_CAST (child_factory));
gst_object_unref (child);
}
}
if (child_name) {
text = g_strdup_printf ("%s + %s", el_name, child_name);
g_free (el_name);
g_free (child_name);
} else {
text = el_name;
}
return text;
}
static GtkSelectionModel *
create_no_selection_closure (ClapperAppInfoWindow *self, ClapperStreamList *stream_list)
{
@@ -218,6 +260,7 @@ clapper_app_info_window_class_init (ClapperAppInfoWindowClass *klass)
gtk_widget_class_bind_template_callback (widget_class, media_duration_closure);
gtk_widget_class_bind_template_callback (widget_class, playback_element_name_closure);
gtk_widget_class_bind_template_callback (widget_class, playback_decoder_closure);
gtk_widget_class_bind_template_callback (widget_class, playback_sink_closure);
gtk_widget_class_bind_template_callback (widget_class, create_no_selection_closure);
gtk_widget_class_bind_template_callback (widget_class, has_streams_closure);
}

4
src/bin/clapper-app/ui/clapper-app-info-window.ui
View File

@@ -181,7 +181,7 @@
<object class="ClapperAppPropertyRow">
<property name="title" translatable="yes">Sink</property>
<binding name="subtitle">
<closure type="gchararray" function="playback_element_name_closure">
<closure type="gchararray" function="playback_sink_closure">
<lookup name="video-sink" type="ClapperPlayer">
<lookup name="player">ClapperAppInfoWindow</lookup>
</lookup>
@@ -222,7 +222,7 @@
<object class="ClapperAppPropertyRow">
<property name="title" translatable="yes">Sink</property>
<binding name="subtitle">
<closure type="gchararray" function="playback_element_name_closure">
<closure type="gchararray" function="playback_sink_closure">
<lookup name="audio-sink" type="ClapperPlayer">
<lookup name="player">ClapperAppInfoWindow</lookup>
</lookup>